chrome/browser/notifications/notification_conversion_helper_unittest.cc - Issue 1825913002: [Extensions] Convert APIs to use movable types [7]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_conversion_helper_unittest.cc

Issue 1825913002: [Extensions] Convert APIs to use movable types [7] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Steven's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_conversion_helper.cc ('k') | chrome/common/extensions/api/language_settings_private.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_conversion_helper_unittest.cc

diff --git a/chrome/browser/notifications/notification_conversion_helper_unittest.cc b/chrome/browser/notifications/notification_conversion_helper_unittest.cc

index 67d3bc1a640c3c355b3d97cc39f008b1698d4f15..e5072949f353038b21b7b56c3b6fd07b38b5b882 100644

--- a/chrome/browser/notifications/notification_conversion_helper_unittest.cc

+++ b/chrome/browser/notifications/notification_conversion_helper_unittest.cc

@@ -89,8 +89,8 @@ TEST_F(NotificationConversionHelperTest, NotificationToNotificationOptions) {

EXPECT_EQ(*(options1->context_message), "I am a context message.");

EXPECT_FALSE(*(options1->is_clickable));

EXPECT_EQ(*(options1->event_time), 12345678.9);

- EXPECT_EQ(options1->buttons->at(0)->title, "Button 1");

- EXPECT_EQ(options1->buttons->at(1)->title, "Button 2");

+ EXPECT_EQ(options1->buttons->at(0).title, "Button 1");

+ EXPECT_EQ(options1->buttons->at(1).title, "Button 2");

EXPECT_EQ(options1->icon_bitmap->width, 1);

EXPECT_EQ(options1->icon_bitmap->height, 1);

@@ -114,8 +114,8 @@ TEST_F(NotificationConversionHelperTest, NotificationToNotificationOptions) {

NotificationConversionHelper::NotificationToNotificationOptions(

*(notification3), options3.get());

EXPECT_EQ(options3->type, extensions::api::notifications::TEMPLATE_TYPE_LIST);

- EXPECT_EQ(options3->items->at(0)->title, "Item 1 Title");

- EXPECT_EQ(options3->items->at(0)->message, "Item 1 Message");

- EXPECT_EQ(options3->items->at(1)->title, "Item 2 Title");

- EXPECT_EQ(options3->items->at(1)->message, "Item 2 Message");

+ EXPECT_EQ(options3->items->at(0).title, "Item 1 Title");

+ EXPECT_EQ(options3->items->at(0).message, "Item 1 Message");

+ EXPECT_EQ(options3->items->at(1).title, "Item 2 Title");

+ EXPECT_EQ(options3->items->at(1).message, "Item 2 Message");

}