Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites. (Closed)

Created:
4 years, 9 months ago by dvadym
Modified:
4 years, 9 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-worker-reviews_chromium.org, caseq+blink_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, extensions-reviews_chromium.org, falken, gavinp+loader_chromium.org, horo+watch_chromium.org, jam, Nate Chapin, kinuko+watch, kinuko+worker_chromium.org, kozyatinskiy+blink_chromium.org, loading-reviews_chromium.org, lushnikov+blink_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, pfeldman, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, tommyw+watchlist_chromium.org, tyoshino+watch_chromium.org, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of https://codereview.chromium.org/1769273004/ ) Reason for revert: Speculative revert, this patch most likely to cause browser_tests failures for Linux (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/26678) Windows (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46875) and Mac Original issue's description: > Remove V8RecrusionScope, cleanup call sites. > > - blink-side usages migrated to v8::MicrotasksScope; > - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope; > - moved Microtask.{h,cpp} to bindings/core/v8; > - removed extra wrappers from V8DebuggerClient; > - fixed a couple of inspector tests which relied on trace event not emitted from debugger anymore. > > BUG=585949 > > Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3 > Cr-Commit-Position: refs/heads/master@{#381103} TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+655 lines, -379 lines) Patch
M chrome/test/base/v8_unit_test.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M components/guest_view/renderer/guest_view_container.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/guest_view/renderer/guest_view_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 8 chunks +8 lines, -14 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/v8_var_converter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/messaging_bindings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/safe_builtins.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/script_context.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M extensions/renderer/utils_native_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/v8_helpers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-bound-function-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-injected-script-eval.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-injected-script-eval-expected.txt View 1 chunk +17 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-recalculate-styles.html View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-recalculate-styles-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-receive-response-event-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-script-id-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-time-expected.txt View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-timer-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/Microtask.h View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/Microtask.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.h View 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 11 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/dom/Microtask.h View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/Microtask.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskRunQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DevToolsHost.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 3 chunks +29 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 19 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp View 4 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp View 11 chunks +18 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 9 chunks +11 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/web/WebScopedMicrotaskSuppression.cpp View 1 chunk +63 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dvadym
Created Revert of Remove V8RecrusionScope, cleanup call sites.
4 years, 9 months ago (2016-03-15 14:07:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804043002/1
4 years, 9 months ago (2016-03-15 14:07:48 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 14:08:47 UTC) #4
Failed to apply patch for
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:237
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp' with
conflicts.
  U third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Patch:       third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
index
dc59c7a50001c7872550ed84d7e709184af1c1ef..ba26c811cb0df93f560a9a13aa1b71c605dc306c
100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
@@ -36,7 +36,6 @@
 #include "platform/v8_inspector/InjectedScriptHost.h"
 #include "platform/v8_inspector/InjectedScriptManager.h"
 #include "platform/v8_inspector/RemoteObjectId.h"
-#include "platform/v8_inspector/V8DebuggerImpl.h"
 #include "platform/v8_inspector/V8FunctionCall.h"
 #include "platform/v8_inspector/V8StringUtil.h"
 #include "platform/v8_inspector/public/V8Debugger.h"
@@ -116,11 +115,12 @@
     data.GetParameter()->dispose();
 }
 
-InjectedScript::InjectedScript(InjectedScriptManager* manager,
v8::Local<v8::Context> context, v8::Local<v8::Object> object,
PassOwnPtr<InjectedScriptNative> injectedScriptNative, int contextId)
+InjectedScript::InjectedScript(InjectedScriptManager* manager,
v8::Local<v8::Context> context, v8::Local<v8::Object> object, V8DebuggerClient*
client, PassOwnPtr<InjectedScriptNative> injectedScriptNative, int contextId)
     : m_manager(manager)
     , m_isolate(context->GetIsolate())
     , m_context(m_isolate, context)
     , m_value(m_isolate, object)
+    , m_client(client)
     , m_native(injectedScriptNative)
     , m_contextId(contextId)
 {
@@ -134,7 +134,7 @@
 void InjectedScript::evaluate(ErrorString* errorString, const String16&
expression, const String16& objectGroup, bool includeCommandLineAPI, bool
returnByValue, bool generatePreview, OwnPtr<protocol::Runtime::RemoteObject>*
result, Maybe<bool>* wasThrown, Maybe<protocol::Runtime::ExceptionDetails>*
exceptionDetails)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"evaluate");
+    V8FunctionCall function(m_client, context(), v8Value(), "evaluate");
     function.appendArgument(expression);
     function.appendArgument(objectGroup);
     function.appendArgument(includeCommandLineAPI);
@@ -146,7 +146,7 @@
 void InjectedScript::callFunctionOn(ErrorString* errorString, const String16&
objectId, const String16& expression, const String16& arguments, bool
returnByValue, bool generatePreview, OwnPtr<protocol::Runtime::RemoteObject>*
result, Maybe<bool>* wasThrown)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"callFunctionOn");
+    V8FunctionCall function(m_client, context(), v8Value(), "callFunctionOn");
     function.appendArgument(objectId);
     function.appendArgument(expression);
     function.appendArgument(arguments);
@@ -158,7 +158,7 @@
 void InjectedScript::evaluateOnCallFrame(ErrorString* errorString,
v8::Local<v8::Object> callFrames, const String16& callFrameId, const String16&
expression, const String16& objectGroup, bool includeCommandLineAPI, bool
returnByValue, bool generatePreview, OwnPtr<RemoteObject>* result, Maybe<bool>*
wasThrown, Maybe<protocol::Runtime::ExceptionDetails>* exceptionDetails)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"evaluateOnCallFrame");
+    V8FunctionCall function(m_client, context(), v8Value(),
"evaluateOnCallFrame");
     function.appendArgument(callFrames);
     function.appendArgument(callFrameId);
     function.appendArgument(expression);
@@ -172,7 +172,7 @@
 void InjectedScript::restartFrame(ErrorString* errorString,
v8::Local<v8::Object> callFrames, const String16& callFrameId)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"restartFrame");
+    V8FunctionCall function(m_client, context(), v8Value(), "restartFrame");
     function.appendArgument(callFrames);
     function.appendArgument(callFrameId);
     OwnPtr<protocol::Value> resultValue = makeCall(function);
@@ -197,7 +197,7 @@
     const String16& newValueStr)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"setVariableValue");
+    V8FunctionCall function(m_client, context(), v8Value(),
"setVariableValue");
     if (callFrameIdOpt.isJust()) {
         function.appendArgument(callFrames);
         function.appendArgument(callFrameIdOpt.fromJust());
@@ -227,7 +227,7 @@
 void InjectedScript::getFunctionDetails(ErrorString* errorString, const
String16& functionId, OwnPtr<FunctionDetails>* result)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"getFunctionDetails");
+    V8FunctionCall function(m_client, context(), v8Value(),
"getFunctionDetails");
     function.appendArgument(functionId);
     OwnPtr<protocol::Value> resultValue = makeCall(function);
     protocol::ErrorSupport errors(errorString);
@@ -237,7 +237,7 @@
 void InjectedScript::getGeneratorObjectDetails(ErrorString* errorString, const
String16& objectId, OwnPtr<GeneratorObjectDetails>* result)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"getGeneratorObjectDetails");
+    V8FunctionCall function(m_client, context(), v8Value(),
"getGeneratorObjectDetails");
     function.appendArgument(objectId);
     OwnPtr<protocol::Value> resultValue = makeCall(function);
     protocol::ErrorSupport errors(errorString);
@@ -247,7 +247,7 @@
 void InjectedScript::getCollectionEntries(ErrorString* errorString, const
String16& objectId, OwnPtr<Array<CollectionEntry>>* result)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"getCollectionEntries");
+    V8FunctionCall function(m_client, context(), v8Value(),
"getCollectionEntries");
     function.appendArgument(objectId);
     OwnPtr<protocol::Value> resultValue = makeCall(function);
     protocol::ErrorSupport errors(errorString);
@@ -257,7 +257,7 @@
 void InjectedScript::getProperties(ErrorString* errorString, const String16&
objectId, bool ownProperties, bool accessorPropertiesOnly, bool generatePreview,
OwnPtr<Array<PropertyDescriptor>>* properties,
Maybe<protocol::Runtime::ExceptionDetails>* exceptionDetails)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"getProperties");
+    V8FunctionCall function(m_client, context(), v8Value(), "getProperties");
     function.appendArgument(objectId);
     function.appendArgument(ownProperties);
     function.appendArgument(accessorPropertiesOnly);
@@ -276,7 +276,7 @@
 void InjectedScript::getInternalProperties(ErrorString* errorString, const
String16& objectId, Maybe<Array<InternalPropertyDescriptor>>* properties,
Maybe<protocol::Runtime::ExceptionDetails>* exceptionDetails)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"getInternalProperties");
+    V8FunctionCall function(m_client, context(), v8Value(),
"getInternalProperties");
     function.appendArgument(objectId);
 
     OwnPtr<protocol::Value> result = makeCallWithExceptionDetails(function,
exceptionDetails);
@@ -307,14 +307,14 @@
     v8::Local<v8::Symbol> commandLineAPISymbolValue =
V8Debugger::commandLineAPISymbol(m_isolate);
     v8::Local<v8::Object> global = context()->Global();
     if (includeCommandLineAPI) {
-        V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"commandLineAPI");
+        V8FunctionCall function(m_client, context(), v8Value(),
"commandLineAPI");
         bool hadException = false;
         v8::Local<v8::Value> commandLineAPI = function.call(hadException,
false);
         if (!hadException)
             global->Set(commandLineAPISymbolValue, commandLineAPI);
     }
 
-    v8::MaybeLocal<v8::Value> maybeValue =
m_manager->debugger()->runCompiledScript(context(), script);
+    v8::MaybeLocal<v8::Value> maybeValue =
m_client->runCompiledScript(context(), script);
     if (includeCommandLineAPI)
         global->Delete(context(), commandLineAPISymbolValue);
 
@@ -324,7 +324,7 @@
 PassOwnPtr<Array<CallFrame>>
InjectedScript::wrapCallFrames(v8::Local<v8::Object> callFrames)
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"wrapCallFrames");
+    V8FunctionCall function(m_client, context(), v8Value(), "wrapCallFrames");
     function.appendArgument(callFrames);
     bool hadException = false;
     v8::Local<v8::Value> callFramesValue =
callFunctionWithEvalEnabled(function, hadException);
@@ -339,7 +339,7 @@
 PassOwnPtr<protocol::Runtime::RemoteObject>
InjectedScript::wrapObject(v8::Local<v8::Value> value, const String16&
groupName, bool generatePreview) const
 {
     v8::HandleScope handles(m_isolate);
-    V8FunctionCall function(m_manager->debugger(), context(), v8Value(),
"wrapObject");
+    V8FunctionCall function(m_client, context(), v8Value(), "wrapObject");
     function.appendArgument(value);
     function.appendArgument(groupName);
     function.appendArgument(canAccessInspectedWindow());
@@ -355,7 +355,7 @@
 PassOwnPtr<protocol::Runtime::RemoteObject>
InjectedScript::wrapTable(v8::Local<v8::Value> table, v8::Loca…
(message too large)

Powered by Google App Engine
This is Rietveld 408576698