Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h

Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h b/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h
index ab393f96b0934063ef859587d9b9bc8140ac941b..f13c507853c39cb3f262420c54b2a50ad0eb33f6 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h
@@ -10,6 +10,8 @@
#include <v8.h>
namespace blink {
+
+class V8DebuggerClient;
class InspectorWrapperBase {
public:
@@ -26,7 +28,7 @@
static v8::Local<v8::FunctionTemplate> createWrapperTemplate(v8::Isolate*, const char* className, const protocol::Vector<V8MethodConfiguration>& methods, const protocol::Vector<V8AttributeConfiguration>& attributes);
protected:
- static v8::Local<v8::Object> createWrapper(v8::Local<v8::FunctionTemplate>, v8::Local<v8::Context>);
+ static v8::Local<v8::Object> createWrapper(V8DebuggerClient*, v8::Local<v8::FunctionTemplate>, v8::Local<v8::Context>);
static void* unwrap(v8::Local<v8::Context>, v8::Local<v8::Object>, const char* name);
static v8::Local<v8::String> v8InternalizedString(v8::Isolate*, const char* name);
@@ -69,10 +71,10 @@
return InspectorWrapperBase::createWrapperTemplate(isolate, className, methods, attributes);
}
- static v8::Local<v8::Object> wrap(v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context, T* object)
+ static v8::Local<v8::Object> wrap(V8DebuggerClient* client, v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context, T* object)
{
v8::Context::Scope contextScope(context);
- v8::Local<v8::Object> result = InspectorWrapperBase::createWrapper(constructorTemplate, context);
+ v8::Local<v8::Object> result = InspectorWrapperBase::createWrapper(client, constructorTemplate, context);
if (result.IsEmpty())
return v8::Local<v8::Object>();
v8::Isolate* isolate = context->GetIsolate();
@@ -83,10 +85,10 @@
return result;
}
- static v8::Local<v8::Object> wrap(v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context, PassOwnPtr<T> object)
+ static v8::Local<v8::Object> wrap(V8DebuggerClient* client, v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context, PassOwnPtr<T> object)
{
v8::Context::Scope contextScope(context);
- v8::Local<v8::Object> result = InspectorWrapperBase::createWrapper(constructorTemplate, context);
+ v8::Local<v8::Object> result = InspectorWrapperBase::createWrapper(client, constructorTemplate, context);
if (result.IsEmpty())
return v8::Local<v8::Object>();
v8::Isolate* isolate = context->GetIsolate();

Powered by Google App Engine
This is Rietveld 408576698