extensions/renderer/activity_log_converter_strategy_unittest.cc - Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/activity_log_converter_strategy_unittest.cc

Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/v8_var_converter_unittest.cc ('k') | extensions/renderer/guest_view/extensions_guest_view_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/activity_log_converter_strategy_unittest.cc

diff --git a/extensions/renderer/activity_log_converter_strategy_unittest.cc b/extensions/renderer/activity_log_converter_strategy_unittest.cc

index fbb9597d661b69c33e751f0e11bc8cab3d2fd496..aa80447cf4572d93887bed7f0158f410746f7891 100644

--- a/extensions/renderer/activity_log_converter_strategy_unittest.cc

+++ b/extensions/renderer/activity_log_converter_strategy_unittest.cc

@@ -6,6 +6,7 @@

#include "base/values.h"

#include "extensions/renderer/activity_log_converter_strategy.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"

#include "v8/include/v8.h"

using content::V8ValueConverter;

@@ -122,8 +123,7 @@

"};"

"})();";

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

v8::Local<v8::Script> script(

v8::Script::Compile(v8::String::NewFromUtf8(isolate_, source)));

v8::Local<v8::Object> v8_object = script->Run().As<v8::Object>();