content/child/v8_value_converter_impl_unittest.cc - Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites.

Unified Diff: content/child/v8_value_converter_impl_unittest.cc

Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/guest_view/renderer/guest_view_request.cc ('k') | content/renderer/java/gin_java_bridge_value_converter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/v8_value_converter_impl_unittest.cc

diff --git a/content/child/v8_value_converter_impl_unittest.cc b/content/child/v8_value_converter_impl_unittest.cc

index ccb1db5fd5fbdbb658eb04765b96d4ca64cf8ffb..435ea307236db3b6cb607fefecc8372766c625ef 100644

--- a/content/child/v8_value_converter_impl_unittest.cc

+++ b/content/child/v8_value_converter_impl_unittest.cc

@@ -14,6 +14,7 @@

#include "base/values.h"

#include "content/child/v8_value_converter_impl.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"

#include "v8/include/v8.h"

namespace content {

@@ -287,8 +288,7 @@

v8::Local<v8::Context> context =

v8::Local<v8::Context>::New(isolate_, context_);

v8::Context::Scope context_scope(context);

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

// Set up objects to throw when reading or writing 'foo'.

const char* source =

@@ -331,8 +331,7 @@

v8::Local<v8::Context> context =

v8::Local<v8::Context>::New(isolate_, context_);

v8::Context::Scope context_scope(context);

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

const char* source = "(function() {"

"var arr = [];"

@@ -409,8 +408,7 @@

v8::Local<v8::Context> context =

v8::Local<v8::Context>::New(isolate_, context_);

v8::Context::Scope context_scope(context);

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

const char* source = "(function() {"

"Object.prototype.foo = 'foo';"

@@ -435,8 +433,7 @@

v8::Local<v8::Context> context =

v8::Local<v8::Context>::New(isolate_, context_);

v8::Context::Scope context_scope(context);

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

const char* source = "(function() {"

"return { foo: undefined, bar: null };"

@@ -495,8 +492,7 @@

v8::Local<v8::Context> context =

v8::Local<v8::Context>::New(isolate_, context_);

v8::Context::Scope context_scope(context);

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

const char* source = "(function() {"

"return {"

@@ -535,8 +531,7 @@

v8::Local<v8::Context> context =

v8::Local<v8::Context>::New(isolate_, context_);

v8::Context::Scope context_scope(context);

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

const char* source = "(function() {"

"var a = [0];"

@@ -561,8 +556,7 @@

v8::Local<v8::Context> context =

v8::Local<v8::Context>::New(isolate_, context_);

v8::Context::Scope context_scope(context);

- v8::MicrotasksScope microtasks(

- isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);

+ blink::WebScopedMicrotaskSuppression microtasks_scope;

v8::Local<v8::Object> object;

{