third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp - Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

index 84cd04c4c7478155ff1e0a377b17d8ee6f9c1a54..32053d4b774483ce06234e3116d4e5034b3af71b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

@@ -45,6 +45,7 @@

v8::Isolate* isolate = m_debugger->isolate();

v8::HandleScope handleScope(isolate);

v8::Local<v8::Context> context = m_debugger->regexContext();

+ v8::Context::Scope contextScope(context);

v8::TryCatch tryCatch(isolate);

v8::Local<v8::RegExp> regex = m_regex.Get(isolate);

@@ -53,7 +54,7 @@

return -1;

v8::Local<v8::Value> argv[] = { toV8String(isolate, string.substring(startFrom)) };

v8::Local<v8::Value> returnValue;

- if (!exec.As<v8::Function>()->Call(context, regex, WTF_ARRAY_LENGTH(argv), argv).ToLocal(&returnValue))

+ if (!m_debugger->client()->callInternalFunction(exec.As<v8::Function>(), regex, WTF_ARRAY_LENGTH(argv), argv).ToLocal(&returnValue))

return -1;

// RegExp#exec returns null if there's no match, otherwise it returns an