Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: components/guest_view/renderer/guest_view_container.cc

Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | components/guest_view/renderer/guest_view_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/guest_view/renderer/guest_view_container.cc
diff --git a/components/guest_view/renderer/guest_view_container.cc b/components/guest_view/renderer/guest_view_container.cc
index 4d8df382fbe64f00cf9094f30f1bc06c547f8cb4..c410c6f67789f17787657c550e173a06c8b64de4 100644
--- a/components/guest_view/renderer/guest_view_container.cc
+++ b/components/guest_view/renderer/guest_view_container.cc
@@ -11,6 +11,7 @@
#include "content/public/renderer/render_frame.h"
#include "content/public/renderer/render_frame_observer.h"
#include "content/public/renderer/render_view.h"
+#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"
namespace {
@@ -153,7 +154,7 @@
void GuestViewContainer::RunDestructionCallback(bool embedder_frame_destroyed) {
// Do not attempt to run |destruction_callback_| if the embedder frame was
// destroyed. Trying to invoke callback on RenderFrame destruction results in
- // assertion failure when calling v8::MicrotasksScope.
+ // assertion failure when calling WebScopedMicrotaskSuppression.
if (embedder_frame_destroyed)
return;
@@ -167,8 +168,7 @@
return;
v8::Context::Scope context_scope(context);
- v8::MicrotasksScope microtasks(
- destruction_isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);
+ blink::WebScopedMicrotaskSuppression suppression;
callback->Call(context->Global(), 0 /* argc */, nullptr);
}
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | components/guest_view/renderer/guest_view_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698