third_party/WebKit/Source/core/inspector/DevToolsHost.cpp - Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

Issue 1804043002: Revert of Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

diff --git a/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp b/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

index fa123be02e39f1a7febbef9a3ed1b205e06c9ac2..fc66082076b3aa6c414f6ca9d4db5f3be09f5e86 100644

--- a/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

+++ b/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

@@ -30,6 +30,7 @@

#include "core/inspector/DevToolsHost.h"

#include "bindings/core/v8/ScriptState.h"

+#include "bindings/core/v8/V8RecursionScope.h"

#include "bindings/core/v8/V8ScriptRunner.h"

#include "core/clipboard/Pasteboard.h"

#include "core/dom/ExecutionContext.h"

@@ -146,7 +147,7 @@

return;

ScriptState::Scope scope(scriptState);

UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);

- v8::MicrotasksScope microtasks(scriptState->isolate(), v8::MicrotasksScope::kRunMicrotasks);

+ V8RecursionScope recursionScope(scriptState->isolate());

v8::Local<v8::String> source = v8AtomicString(scriptState->isolate(), expression.utf8().data());

V8ScriptRunner::compileAndRunInternalScript(source, scriptState->isolate(), String(), TextPosition());

}