Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1800863002: Cleanup in //runtime/bin (Closed)

Created:
4 years, 9 months ago by zra
Modified:
4 years, 9 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Windows fixes #

Total comments: 16

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1217 lines, -775 lines) Patch
M runtime/bin/builtin.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/builtin_gen_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/builtin_natives.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/bin/builtin_nolib.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/crypto_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/crypto_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/crypto_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/directory.cc View 10 chunks +12 lines, -11 lines 0 comments Download
M runtime/bin/directory_android.cc View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M runtime/bin/directory_linux.cc View 1 2 3 4 3 chunks +3 lines, -7 lines 0 comments Download
M runtime/bin/directory_macos.cc View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M runtime/bin/embedded_dart_io.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler.h View 10 chunks +17 lines, -4 lines 0 comments Download
M runtime/bin/eventhandler.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M runtime/bin/eventhandler_android.h View 5 chunks +11 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_android.cc View 1 2 3 6 chunks +39 lines, -20 lines 0 comments Download
M runtime/bin/eventhandler_linux.h View 4 chunks +11 lines, -0 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 2 3 7 chunks +36 lines, -19 lines 0 comments Download
M runtime/bin/eventhandler_macos.h View 4 chunks +11 lines, -0 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 3 7 chunks +38 lines, -17 lines 0 comments Download
M runtime/bin/eventhandler_win.h View 12 chunks +24 lines, -3 lines 0 comments Download
M runtime/bin/eventhandler_win.cc View 1 2 3 26 chunks +89 lines, -54 lines 0 comments Download
M runtime/bin/extensions.h View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/extensions.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M runtime/bin/extensions_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/extensions_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/extensions_macos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/extensions_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/fdutils.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/fdutils_android.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M runtime/bin/fdutils_linux.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M runtime/bin/fdutils_macos.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M runtime/bin/file.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/bin/file_android.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/file_system_watcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/file_system_watcher_android.cc View 1 2 3 4 chunks +40 lines, -14 lines 0 comments Download
M runtime/bin/file_system_watcher_linux.cc View 1 2 3 5 chunks +43 lines, -15 lines 0 comments Download
M runtime/bin/file_system_watcher_macos.cc View 1 2 3 11 chunks +37 lines, -14 lines 0 comments Download
M runtime/bin/file_system_watcher_win.cc View 1 2 3 4 chunks +23 lines, -10 lines 0 comments Download
M runtime/bin/file_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/file_win.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M runtime/bin/filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/filter_unsupported.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/gen_snapshot.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M runtime/bin/io_buffer.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/bin/io_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/io_natives.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/io_natives.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/io_service.h View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/io_service.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M runtime/bin/io_service_no_ssl.h View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/io_service_no_ssl.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M runtime/bin/io_service_unsupported.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/isolate_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/lockers.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/log.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/bin/log_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/log_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/log_macos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/log_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/platform.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/platform_macos.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/process.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/process.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_android.cc View 1 2 3 24 chunks +64 lines, -36 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 2 3 24 chunks +65 lines, -38 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 2 3 25 chunks +66 lines, -39 lines 0 comments Download
M runtime/bin/process_win.cc View 1 2 3 27 chunks +86 lines, -49 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/secure_socket.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/secure_socket.cc View 1 2 3 5 chunks +4 lines, -8 lines 0 comments Download
M runtime/bin/secure_socket_unsupported.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/snapshot_empty.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/snapshot_in.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/socket.h View 1 12 chunks +38 lines, -20 lines 0 comments Download
M runtime/bin/socket.cc View 1 16 chunks +41 lines, -22 lines 0 comments Download
M runtime/bin/socket_android.cc View 1 2 3 18 chunks +40 lines, -33 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 18 chunks +46 lines, -35 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 17 chunks +43 lines, -39 lines 0 comments Download
M runtime/bin/socket_win.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 12 chunks +21 lines, -24 lines 0 comments Download
M runtime/bin/stdio.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/stdio.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/stdio_android.cc View 1 2 3 5 chunks +8 lines, -9 lines 0 comments Download
M runtime/bin/stdio_linux.cc View 1 2 3 5 chunks +8 lines, -9 lines 0 comments Download
M runtime/bin/stdio_macos.cc View 1 2 3 5 chunks +8 lines, -9 lines 0 comments Download
M runtime/bin/stdio_win.cc View 1 2 3 6 chunks +17 lines, -8 lines 0 comments Download
M runtime/bin/thread.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/thread_android.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M runtime/bin/thread_linux.cc View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M runtime/bin/thread_macos.cc View 1 2 3 3 chunks +10 lines, -7 lines 0 comments Download
M runtime/bin/thread_win.cc View 1 2 3 8 chunks +12 lines, -7 lines 0 comments Download
M runtime/bin/utils.h View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/bin/utils_android.cc View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M runtime/bin/utils_linux.cc View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M runtime/bin/utils_macos.cc View 1 2 3 4 chunks +15 lines, -8 lines 0 comments Download
M runtime/bin/utils_win.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/utils_win.cc View 1 2 3 2 chunks +13 lines, -12 lines 0 comments Download
M runtime/bin/vmservice_dartium.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice_impl.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
This CL makes a few more things scope allocated. I've noted them in the CL. ...
4 years, 9 months ago (2016-03-15 18:12:30 UTC) #2
Ivan Posva
LGTM -Ivan https://codereview.chromium.org/1800863002/diff/40001/runtime/bin/directory_macos.cc File runtime/bin/directory_macos.cc (right): https://codereview.chromium.org/1800863002/diff/40001/runtime/bin/directory_macos.cc#newcode367 runtime/bin/directory_macos.cc:367: char buffer[PATH_MAX]; On 2016/03/15 18:12:29, zra wrote: ...
4 years, 9 months ago (2016-03-16 07:33:51 UTC) #3
zra
https://codereview.chromium.org/1800863002/diff/40001/runtime/bin/directory_macos.cc File runtime/bin/directory_macos.cc (right): https://codereview.chromium.org/1800863002/diff/40001/runtime/bin/directory_macos.cc#newcode367 runtime/bin/directory_macos.cc:367: char buffer[PATH_MAX]; On 2016/03/16 07:33:51, Ivan Posva wrote: > ...
4 years, 9 months ago (2016-03-16 17:00:13 UTC) #4
zra
4 years, 9 months ago (2016-03-16 17:01:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
45661a709104f7135d3333db3b7aa9c2d5e6e1c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698