Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: runtime/bin/thread_macos.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/thread_linux.cc ('k') | runtime/bin/thread_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/thread_macos.cc
diff --git a/runtime/bin/thread_macos.cc b/runtime/bin/thread_macos.cc
index 28c747d65073ea25ffe9f1eca71904d54278a779..8286835897438152876daeb8432bd409c3e7c1f8 100644
--- a/runtime/bin/thread_macos.cc
+++ b/runtime/bin/thread_macos.cc
@@ -6,17 +6,18 @@
#if defined(TARGET_OS_MACOS)
#include "bin/thread.h"
+#include "bin/thread_macos.h"
-#include <sys/errno.h> // NOLINT
-#include <sys/types.h> // NOLINT
-#include <sys/sysctl.h> // NOLINT
-#include <mach/mach_init.h> // NOLINT
#include <mach/mach_host.h> // NOLINT
+#include <mach/mach_init.h> // NOLINT
#include <mach/mach_port.h> // NOLINT
#include <mach/mach_traps.h> // NOLINT
#include <mach/task_info.h> // NOLINT
-#include <mach/thread_info.h> // NOLINT
#include <mach/thread_act.h> // NOLINT
+#include <mach/thread_info.h> // NOLINT
+#include <sys/errno.h> // NOLINT
+#include <sys/sysctl.h> // NOLINT
+#include <sys/types.h> // NOLINT
#include "platform/assert.h"
#include "platform/utils.h"
@@ -45,7 +46,9 @@ namespace bin {
}
#else
#define RETURN_ON_PTHREAD_FAILURE(result) \
- if (result != 0) return result;
+ if (result != 0) { \
+ return result; \
+ }
#endif
@@ -157,7 +160,7 @@ intptr_t Thread::ThreadIdToIntPtr(ThreadId id) {
bool Thread::Compare(ThreadId a, ThreadId b) {
- return pthread_equal(a, b) != 0;
+ return (pthread_equal(a, b) != 0);
}
« no previous file with comments | « runtime/bin/thread_linux.cc ('k') | runtime/bin/thread_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698