Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: runtime/bin/main.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/log_win.cc ('k') | runtime/bin/platform.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 4601588bf163931c2492d9257626ff2101d5a43c..3d4fe791c24323ef49bf218795dafd5cd6c9d149 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -218,7 +218,7 @@ static bool ProcessPackageRootOption(const char* arg,
static bool ProcessPackagesOption(const char* arg,
CommandLineOptions* vm_options) {
ASSERT(arg != NULL);
- if (*arg == '\0' || *arg == '-') {
+ if ((*arg == '\0') || (*arg == '-')) {
return false;
}
commandline_packages_file = arg;
@@ -1076,7 +1076,7 @@ static void WriteSnapshotFile(const char* snapshot_directory,
const intptr_t size) {
char* concat = NULL;
const char* qualified_filename;
- if ((snapshot_directory != NULL) && strlen(snapshot_directory) > 0) {
+ if ((snapshot_directory != NULL) && (strlen(snapshot_directory) > 0)) {
intptr_t len = snprintf(NULL, 0, "%s/%s", snapshot_directory, filename);
concat = new char[len + 1];
snprintf(concat, len + 1, "%s/%s", snapshot_directory, filename);
@@ -1110,7 +1110,7 @@ static void ReadSnapshotFile(const char* snapshot_directory,
const uint8_t** buffer) {
char* concat = NULL;
const char* qualified_filename;
- if ((snapshot_directory != NULL) && strlen(snapshot_directory) > 0) {
+ if ((snapshot_directory != NULL) && (strlen(snapshot_directory) > 0)) {
intptr_t len = snprintf(NULL, 0, "%s/%s", snapshot_directory, filename);
concat = new char[len + 1];
snprintf(concat, len + 1, "%s/%s", snapshot_directory, filename);
@@ -1129,7 +1129,7 @@ static void ReadSnapshotFile(const char* snapshot_directory,
}
intptr_t len = -1;
DartUtils::ReadFile(buffer, &len, file);
- if (*buffer == NULL || len == -1) {
+ if ((*buffer == NULL) || (len == -1)) {
fprintf(stderr,
"Error: Unable to read snapshot file %s\n", qualified_filename);
fflush(stderr);
@@ -1147,7 +1147,7 @@ static void* LoadLibrarySymbol(const char* snapshot_directory,
const char* symname) {
char* concat = NULL;
const char* qualified_libname;
- if ((snapshot_directory != NULL) && strlen(snapshot_directory) > 0) {
+ if ((snapshot_directory != NULL) && (strlen(snapshot_directory) > 0)) {
intptr_t len = snprintf(NULL, 0, "%s/%s", snapshot_directory, libname);
concat = new char[len + 1];
snprintf(concat, len + 1, "%s/%s", snapshot_directory, libname);
« no previous file with comments | « runtime/bin/log_win.cc ('k') | runtime/bin/platform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698