Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: runtime/bin/eventhandler_macos.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/eventhandler_macos.h ('k') | runtime/bin/eventhandler_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_macos.cc
diff --git a/runtime/bin/eventhandler_macos.cc b/runtime/bin/eventhandler_macos.cc
index faf471b2a0f02e1ac4a1f6664a97fd1ad71f591d..8d4c683fc3876f1214770bea8cb334e287c5c6ae 100644
--- a/runtime/bin/eventhandler_macos.cc
+++ b/runtime/bin/eventhandler_macos.cc
@@ -9,12 +9,12 @@
#include "bin/eventhandler_macos.h"
#include <errno.h> // NOLINT
+#include <fcntl.h> // NOLINT
#include <pthread.h> // NOLINT
#include <stdio.h> // NOLINT
#include <string.h> // NOLINT
#include <sys/event.h> // NOLINT
#include <unistd.h> // NOLINT
-#include <fcntl.h> // NOLINT
#include "bin/dartutils.h"
#include "bin/fdutils.h"
@@ -26,11 +26,9 @@
#include "platform/hashmap.h"
#include "platform/utils.h"
-
namespace dart {
namespace bin {
-
bool DescriptorInfo::HasReadEvent() {
return (Mask() & (1 << kInEvent)) != 0;
}
@@ -43,7 +41,9 @@ bool DescriptorInfo::HasWriteEvent() {
// Unregister the file descriptor for a SocketData structure with kqueue.
static void RemoveFromKqueue(intptr_t kqueue_fd_, DescriptorInfo* di) {
- if (!di->tracked_by_kqueue()) return;
+ if (!di->tracked_by_kqueue()) {
+ return;
+ }
static const intptr_t kMaxChanges = 2;
struct kevent events[kMaxChanges];
EV_SET(events, di->fd(), EVFILT_READ, EV_DELETE, 0, 0, NULL);
@@ -150,9 +150,9 @@ void EventHandlerImplementation::UpdateKQueueInstance(intptr_t old_mask,
intptr_t new_mask = di->Mask();
if (old_mask != 0 && new_mask == 0) {
RemoveFromKqueue(kqueue_fd_, di);
- } else if (old_mask == 0 && new_mask != 0) {
+ } else if ((old_mask == 0) && (new_mask != 0)) {
AddToKqueue(kqueue_fd_, di);
- } else if (old_mask != 0 && new_mask != 0 && old_mask != new_mask) {
+ } else if ((old_mask != 0) && (new_mask != 0) && (old_mask != new_mask)) {
ASSERT(!di->IsListeningSocket());
RemoveFromKqueue(kqueue_fd_, di);
AddToKqueue(kqueue_fd_, di);
@@ -281,22 +281,39 @@ void EventHandlerImplementation::HandleInterruptFd() {
}
}
+
#ifdef DEBUG_KQUEUE
static void PrintEventMask(intptr_t fd, struct kevent* event) {
Log::Print("%d ", static_cast<int>(fd));
+
Log::Print("filter=0x%x:", event->filter);
- if (event->filter == EVFILT_READ) Log::Print("EVFILT_READ ");
- if (event->filter == EVFILT_WRITE) Log::Print("EVFILT_WRITE ");
+ if (event->filter == EVFILT_READ) {
+ Log::Print("EVFILT_READ ");
+ }
+ if (event->filter == EVFILT_WRITE) {
+ Log::Print("EVFILT_WRITE ");
+ }
+
Log::Print("flags: %x: ", event->flags);
- if ((event->flags & EV_EOF) != 0) Log::Print("EV_EOF ");
- if ((event->flags & EV_ERROR) != 0) Log::Print("EV_ERROR ");
- if ((event->flags & EV_CLEAR) != 0) Log::Print("EV_CLEAR ");
- if ((event->flags & EV_ADD) != 0) Log::Print("EV_ADD ");
- if ((event->flags & EV_DELETE) != 0) Log::Print("EV_DELETE ");
+ if ((event->flags & EV_EOF) != 0) {
+ Log::Print("EV_EOF ");
+ }
+ if ((event->flags & EV_ERROR) != 0) {
+ Log::Print("EV_ERROR ");
+ }
+ if ((event->flags & EV_CLEAR) != 0) {
+ Log::Print("EV_CLEAR ");
+ }
+ if ((event->flags & EV_ADD) != 0) {
+ Log::Print("EV_ADD ");
+ }
+ if ((event->flags & EV_DELETE) != 0) {
+ Log::Print("EV_DELETE ");
+ }
+
Log::Print("- fflags: %d ", event->fflags);
Log::Print("- data: %ld ", event->data);
- Log::Print("(available %d) ",
- static_cast<int>(FDUtils::AvailableBytes(fd)));
+ Log::Print("(available %d) ", static_cast<int>(FDUtils::AvailableBytes(fd)));
Log::Print("\n");
}
#endif
@@ -319,7 +336,9 @@ intptr_t EventHandlerImplementation::GetEvents(struct kevent* event,
event_mask |= (1 << kCloseEvent);
}
}
- if (event_mask == 0) event_mask |= (1 << kInEvent);
+ if (event_mask == 0) {
+ event_mask |= (1 << kInEvent);
+ }
} else {
UNREACHABLE();
}
@@ -421,7 +440,9 @@ void EventHandlerImplementation::EventHandlerEntry(uword args) {
while (!handler_impl->shutdown_) {
int64_t millis = handler_impl->GetTimeout();
ASSERT(millis == kInfinityTimeout || millis >= 0);
- if (millis > kMaxInt32) millis = kMaxInt32;
+ if (millis > kMaxInt32) {
+ millis = kMaxInt32;
+ }
// NULL pointer timespec for infinite timeout.
ASSERT(kInfinityTimeout < 0);
struct timespec* timeout = NULL;
« no previous file with comments | « runtime/bin/eventhandler_macos.h ('k') | runtime/bin/eventhandler_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698