Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: runtime/bin/file_win.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file_test.cc ('k') | runtime/bin/filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_win.cc
diff --git a/runtime/bin/file_win.cc b/runtime/bin/file_win.cc
index 7c1268f1694ff468e91492a3c96ea3fd47a42aa2..054370a3aeedc7a9d98d035ad18877e45eaef49c 100644
--- a/runtime/bin/file_win.cc
+++ b/runtime/bin/file_win.cc
@@ -20,7 +20,6 @@
#include "bin/utils_win.h"
#include "platform/utils.h"
-
namespace dart {
namespace bin {
@@ -110,7 +109,7 @@ bool File::Flush() {
bool File::Lock(File::LockType lock, int64_t start, int64_t end) {
ASSERT(handle_->fd() >= 0);
- ASSERT(end == -1 || end > start);
+ ASSERT((end == -1) || (end > start));
HANDLE handle = reinterpret_cast<HANDLE>(_get_osfhandle(handle_->fd()));
OVERLAPPED overlapped;
ZeroMemory(&overlapped, sizeof(OVERLAPPED));
@@ -125,7 +124,6 @@ bool File::Lock(File::LockType lock, int64_t start, int64_t end) {
int32_t length_low = Utils::Low32Bits(length);
int32_t length_high = Utils::High32Bits(length);
-
BOOL rc;
switch (lock) {
case File::kLockUnlock:
@@ -549,9 +547,9 @@ bool File::IsAbsolutePath(const char* pathname) {
if (pathname == NULL) {
return false;
}
- return (strlen(pathname) > 2) &&
+ return ((strlen(pathname) > 2) &&
(pathname[1] == ':') &&
- (pathname[2] == '\\' || pathname[2] == '/');
+ ((pathname[2] == '\\') || (pathname[2] == '/')));
}
« no previous file with comments | « runtime/bin/file_test.cc ('k') | runtime/bin/filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698