Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: runtime/bin/file_android.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file.cc ('k') | runtime/bin/file_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_android.cc
diff --git a/runtime/bin/file_android.cc b/runtime/bin/file_android.cc
index c6729147fb9bfe790f41a351c0ff074eea8bc92f..a115715b2c3209bb16b0071d1d75d5aad8665ffa 100644
--- a/runtime/bin/file_android.cc
+++ b/runtime/bin/file_android.cc
@@ -9,11 +9,11 @@
#include <errno.h> // NOLINT
#include <fcntl.h> // NOLINT
+#include <libgen.h> // NOLINT
+#include <sys/sendfile.h> // NOLINT
#include <sys/stat.h> // NOLINT
#include <sys/types.h> // NOLINT
-#include <sys/sendfile.h> // NOLINT
#include <unistd.h> // NOLINT
-#include <libgen.h> // NOLINT
#include "bin/builtin.h"
#include "bin/log.h"
@@ -21,7 +21,6 @@
#include "platform/signal_blocker.h"
#include "platform/utils.h"
-
namespace dart {
namespace bin {
@@ -114,7 +113,7 @@ bool File::Flush() {
bool File::Lock(File::LockType lock, int64_t start, int64_t end) {
ASSERT(handle_->fd() >= 0);
- ASSERT(end == -1 || end > start);
+ ASSERT((end == -1) || (end > start));
struct flock fl;
switch (lock) {
case File::kLockUnlock:
@@ -399,7 +398,7 @@ const char* File::LinkTarget(const char* pathname) {
bool File::IsAbsolutePath(const char* pathname) {
- return (pathname != NULL && pathname[0] == '/');
+ return ((pathname != NULL) && (pathname[0] == '/'));
}
« no previous file with comments | « runtime/bin/file.cc ('k') | runtime/bin/file_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698