Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: runtime/bin/fdutils_macos.cc

Issue 1800863002: Cleanup in //runtime/bin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/fdutils_linux.cc ('k') | runtime/bin/file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/fdutils_macos.cc
diff --git a/runtime/bin/fdutils_macos.cc b/runtime/bin/fdutils_macos.cc
index 2ecf6006e4813f0485dcd866c06084ca0d600180..41f1d2434465d2923a0fafac11faeebfa2a9e409 100644
--- a/runtime/bin/fdutils_macos.cc
+++ b/runtime/bin/fdutils_macos.cc
@@ -5,16 +5,15 @@
#include "platform/globals.h"
#if defined(TARGET_OS_MACOS)
+#include "bin/fdutils.h"
+
#include <errno.h> // NOLINT
#include <fcntl.h> // NOLINT
-#include <unistd.h> // NOLINT
#include <sys/ioctl.h> // NOLINT
-
-#include "bin/fdutils.h"
+#include <unistd.h> // NOLINT
#include "platform/signal_blocker.h"
-
namespace dart {
namespace bin {
@@ -73,9 +72,7 @@ intptr_t FDUtils::AvailableBytes(intptr_t fd) {
if (result < 0) {
return result;
}
-#ifdef DEBUG
ASSERT(available >= 0);
-#endif
return static_cast<intptr_t>(available);
}
@@ -99,7 +96,7 @@ ssize_t FDUtils::ReadFromBlocking(int fd, void* buffer, size_t count) {
ASSERT(errno != EWOULDBLOCK);
return -1;
} else {
- ASSERT((bytes_read > 0));
+ ASSERT(bytes_read > 0);
remaining -= bytes_read;
buffer_pos += bytes_read;
}
« no previous file with comments | « runtime/bin/fdutils_linux.cc ('k') | runtime/bin/file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698