Cleanup in //runtime/bin

runtime/bin/directory_macos.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_MACOS)
 
 #include "bin/directory.h"
 
 #include <dirent.h>  // NOLINT
@@ skipping 346 matching lines @@
     ASSERT((errno == ELOOP) ||
            (errno == ENAMETOOLONG) ||
            (errno == ENOENT) ||
            (errno == ENOTDIR));
     return DOES_NOT_EXIST;
   }
 }
 
 
 char* Directory::CurrentNoScope() {
-  return getcwd(NULL, 0);
+  char buffer[PATH_MAX];

[zra, 2016/03/15 18:12:29]

Changed to match other platforms.

[Ivan Posva, 2016/03/16 07:33:51]

It looks like the original was working correctly without the large stack
allocated area. Any reason we do not do this on Linux as well?

[zra, 2016/03/16 17:00:13]

I checked the Linux docs. getcwd(NULL, 0) works there as well, so I've changed
back here and used it there. There's a comment on the Android version saying it
won't work there, so I'll leave it alone.

+  if (getcwd(buffer, PATH_MAX) == NULL) {
+    return NULL;
+  }
+  return strdup(buffer);
 }
 
 
 const char* Directory::Current() {
-  char* result = DartUtils::ScopedCString(PATH_MAX);
-  ASSERT(result != NULL);
-  return getcwd(result, PATH_MAX);
+  char buffer[PATH_MAX];
+  if (getcwd(buffer, PATH_MAX) == NULL) {

[zra, 2016/03/15 18:12:29]

Ported fix from Linux.

+    return NULL;
+  }
+  return DartUtils::ScopedCopyCString(buffer);
 }
 
 
 bool Directory::SetCurrent(const char* path) {
   int result = NO_RETRY_EXPECTED(chdir(path));
-  return result == 0;
+  return (result == 0);
 }
 
 
 bool Directory::Create(const char* dir_name) {
   // Create the directory with the permissions specified by the
   // process umask.
   int result = NO_RETRY_EXPECTED(mkdir(dir_name, 0777));
   // If the directory already exists, treat it as a success.
   if ((result == -1) && (errno == EEXIST)) {
     return (Exists(dir_name) == EXISTS);
@@ skipping 70 matching lines @@
   if (exists != EXISTS) {
     return false;
   }
   return (NO_RETRY_EXPECTED(rename(path, new_path)) == 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_MACOS)