Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1799313002: [Findit] Collect failed output nodes of compile and link failures by strict regex (Closed)

Created:
4 years, 9 months ago by stgao
Modified:
4 years, 9 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Collect failed output nodes of compile and link failures by strict regex This is a temporary solution before the ninja 1.7 is released and used by all bots. This worth a try as it speeds up the culprit-finding try-jobs so much. BUG=592808 Committed: https://chromium.googlesource.com/infra/infra/+/8f5d6b5fbb6086297bb8bbb26b6f7392766ba53b

Patch Set 1 #

Total comments: 14

Patch Set 2 : Address comments. #

Patch Set 3 : Support Android besides Mac/Linux/CrOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -10 lines) Patch
M appengine/findit/handlers/config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M appengine/findit/handlers/test/config_test.py View 1 chunk +18 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/extractors.py View 1 2 4 chunks +42 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/test/extractors_test.py View 1 2 2 chunks +76 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/try_job_util_test.py View 2 chunks +20 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/test/waterfall_config_test.py View 2 chunks +8 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/try_job_util.py View 1 2 chunks +10 lines, -6 lines 0 comments Download
M appengine/findit/waterfall/waterfall_config.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
stgao
PTAL. BTW, I've reviewed the CL by myself yet, so there might be still some ...
4 years, 9 months ago (2016-03-15 00:33:21 UTC) #2
chanli
https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py File appengine/findit/waterfall/extractors.py (right): https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py#newcode134 appengine/findit/waterfall/extractors.py:134: STRICT_COMPILE_FAILURE_PATTEN = re.compile( nit: It seems that the first ...
4 years, 9 months ago (2016-03-15 06:07:49 UTC) #3
lijeffrey
https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py File appengine/findit/waterfall/extractors.py (right): https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py#newcode141 appengine/findit/waterfall/extractors.py:141: STRICT_LINK_FAILURE_PATTEN = re.compile( I'm thinking, would it make sense ...
4 years, 9 months ago (2016-03-15 07:12:26 UTC) #4
stgao
https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py File appengine/findit/waterfall/extractors.py (right): https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py#newcode134 appengine/findit/waterfall/extractors.py:134: STRICT_COMPILE_FAILURE_PATTEN = re.compile( On 2016/03/15 06:07:49, chanli wrote: > ...
4 years, 9 months ago (2016-03-15 18:32:21 UTC) #5
chanli
On 2016/03/15 18:32:21, stgao wrote: > https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py > File appengine/findit/waterfall/extractors.py (right): > > https://codereview.chromium.org/1799313002/diff/1/appengine/findit/waterfall/extractors.py#newcode134 > ...
4 years, 9 months ago (2016-03-15 20:10:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1799313002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1799313002/100001
4 years, 9 months ago (2016-03-15 20:20:18 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 20:23:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/infra/infra/+/8f5d6b5fbb6086297bb8bbb26b6f7...

Powered by Google App Engine
This is Rietveld 408576698