Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: appengine/findit/waterfall/test/waterfall_config_test.py

Issue 1799313002: [Findit] Collect failed output nodes of compile and link failures by strict regex (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Support Android besides Mac/Linux/CrOS Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/test/try_job_util_test.py ('k') | appengine/findit/waterfall/try_job_util.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/waterfall_config_test.py
diff --git a/appengine/findit/waterfall/test/waterfall_config_test.py b/appengine/findit/waterfall/test/waterfall_config_test.py
index 2deb7429387445678976c07cfe30aec3ac60d5fa..1e4d53e18318fad640967670151737992d6cc11f 100644
--- a/appengine/findit/waterfall/test/waterfall_config_test.py
+++ b/appengine/findit/waterfall/test/waterfall_config_test.py
@@ -41,6 +41,7 @@ class MastersTest(testing.AppengineTestCase):
'builder1': {
'mastername': 'tryserver1',
'buildername': 'trybot1',
+ 'strict_regex': True,
}
}
},
@@ -150,3 +151,10 @@ class MastersTest(testing.AppengineTestCase):
'iterations_to_rerun': 10
},
waterfall_config.GetSwarmingSettings())
+
+ def testEnableStrictRegexForCompileLinkFailures(self):
+ self.assertFalse(
+ waterfall_config.EnableStrictRegexForCompileLinkFailures('m', 'b'))
+ self.assertTrue(
+ waterfall_config.EnableStrictRegexForCompileLinkFailures(
+ 'master1', 'builder1'))
« no previous file with comments | « appengine/findit/waterfall/test/try_job_util_test.py ('k') | appengine/findit/waterfall/try_job_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698