[Findit] Collect failed output nodes of compile and link failures by strict regex

appengine/findit/handlers/config.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Handles requests to the findit config page."""
 
 import json
 
 from base_handler import BaseHandler
 from base_handler import Permission
@@ skipping 118 matching lines @@
     return False
   for builders in builders_to_trybots.values():
     if not isinstance(builders, dict):
       return False
     for trybot_config in builders.values():
       if not isinstance(trybot_config, dict):
         return False
       if (not trybot_config.get('mastername') or
           not trybot_config.get('buildername')):
         return False
+      if (trybot_config.has_key('strict_regex') and
+          not isinstance(trybot_config['strict_regex'], bool)):
+        return False
   return True
 
 
 def _ValidateTryJobSettings(settings):
   return (isinstance(settings, dict) and
           isinstance(settings.get('server_query_interval_seconds'), int) and
           isinstance(settings.get('job_timeout_hours'), int) and
           isinstance(settings.get('allowed_response_error_times'), int))
 
 
@@ skipping 87 matching lines @@
   def HandlePost(self):
     data = self.request.params.get('data')
     new_config_dict = json.loads(data)
     if not _ConfigurationDictIsValid(new_config_dict):  # pragma: no cover
       return self.CreateError(
           'New configuration settings is not properly formatted.', 400)
 
     wf_config.FinditConfig.Get().Update(**new_config_dict)
 
     return self.HandleGet()