[Findit] Collect failed output nodes of compile and link failures by strict regex

appengine/findit/waterfall/test/try_job_util_test.py

Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 1a39deb6d49d088006a5addc64010b240bb4bbcf..339550a17bf62aa20d3234080e367792dcbffa70 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -381,7 +381,8 @@ class TryJobUtilTest(testing.AppengineTestCase):
     self.assertIsNotNone(try_job)
 
   def testGetFailedTargetsFromSignals(self):
-    self.assertEqual(try_job_util._GetFailedTargetsFromSignals({}), [])
+    self.assertEqual(
+        try_job_util._GetFailedTargetsFromSignals({}, 'm', 'b'), [])
 
     signals = {
         'compile': {
@@ -393,4 +394,21 @@ class TryJobUtilTest(testing.AppengineTestCase):
     }
 
     self.assertEqual(
-        try_job_util._GetFailedTargetsFromSignals(signals), ['a.exe'])
+        try_job_util._GetFailedTargetsFromSignals(signals, 'm', 'b'), ['a.exe'])
+
+  def testUseObjectFilesAsFailedTargetIfStrictRegexUsed(self):
+    def Mocked_EnableStrictRegexForCompileLinkFailures(*_):
+      return True
+    self.mock(waterfall_config, 'EnableStrictRegexForCompileLinkFailures',
+              Mocked_EnableStrictRegexForCompileLinkFailures)
+
+    signals = {
+        'compile': {
+            'failed_targets': [
+                {'source': 'b.cc', 'target': 'b.o'},
+            ]
+        }
+    }
+
+    self.assertEqual(
+        try_job_util._GetFailedTargetsFromSignals(signals, 'm', 'b'), ['b.o'])