[Findit] Collect failed output nodes of compile and link failures by strict regex

appengine/findit/waterfall/test/extractors_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import textwrap
 
 from testing_utils import testing
 from waterfall import extractors
+from waterfall import waterfall_config
 from waterfall.extractor import Extractor
 
 
 class ExtractorsTest(testing.AppengineTestCase):
 
   def _RunTest(self, failure_log, extractor_class, expected_signal_json,
                bot='bot', master='master'):
     signal = extractor_class().Extract(
         failure_log, 'suite.test', 'step', bot, master)
     self.assertEqual(expected_signal_json, signal.ToDict())
@@ skipping 482 matching lines @@
             'a/c/in_signal_5.cc': [],
             'a/c/in_signal_6.cc': []
         },
         'keywords': {}
     }
 
     self._RunTest(
         failure_log, extractors.CompileStepExtractor, expected_signal_json,
         'iOS_Simulator_(dbg)', 'chromium.mac')
 
+  def testCompileStepStrictRegexForCompileFailures(self):
+    def Mocked_EnableStrictRegexForCompileLinkFailures(*_):
+      return True
+    self.mock(waterfall_config, 'EnableStrictRegexForCompileLinkFailures',
+              Mocked_EnableStrictRegexForCompileLinkFailures)
+
+    goma_clang_prefix = (
+        '/b/build/goma/gomacc '
+        '../../third_party/llvm-build/Release+Asserts/bin/clang++ '
+        '-MMD -MF')
+    failure_log = textwrap.dedent("""
+        [1832/2467 | 117.498] CXX obj/a/b/test.file.o
+        blabla...
+        FAILED: %s obj/a.o.d ... -c a.c -o obj/a.o
+        blalba...
+        FAILED: %s obj/b.o.d ... -c a.c -o obj/c.o
+        blalba...
+        FAILED with 1: %s obj/f.o.d -c f.c -o obj/f.o
+        ninja: build stopped: subcommand failed.
+
+        /b/build/goma/goma_ctl.sh stat
+        blabla...""" % (
+            goma_clang_prefix, goma_clang_prefix, goma_clang_prefix))
+    expected_signal_json = {
+        'files': {
+            'obj/f.o': [],
+            'f.c': [],
+        },
+        'keywords': {},
+        'failed_targets': [
+            {
+                'source': 'a.c',
+                'target': 'obj/a.o',
+            },
+        ]
+    }
+
+    self._RunTest(
+        failure_log, extractors.CompileStepExtractor, expected_signal_json)
+
+
+  def testCompileStepStrictRegexForLinkFailures(self):
+    def Mocked_EnableStrictRegexForCompileLinkFailures(*_):
+      return True
+    self.mock(waterfall_config, 'EnableStrictRegexForCompileLinkFailures',
+              Mocked_EnableStrictRegexForCompileLinkFailures)

[chanli, 2016/03/15 06:07:49]

nit: we can reuse this mock from  testCompileStepStrictRegexForCompileFailures

[stgao, 2016/03/15 18:32:21]

Done.

+
+    goma_clang_prefix = (
+        '/b/build/goma/gomacc '
+        '../../third_party/llvm-build/Release+Asserts/bin/clang++')
+    failure_log = textwrap.dedent("""
+        [1832/2467 | 117.498] CXX obj/a/b/test.file.o
+        blabla...
+        FAILED: %s -Wl,-z,now ... -o exe -Wl,--start-group obj/a.o ...
+        blalba...
+        FAILED: cd a/b/c; python script.py a b c blabla....
+        blalba...
+        ninja: build stopped: subcommand failed.
+
+        /b/build/goma/goma_ctl.sh stat
+        blabla...""" % goma_clang_prefix)
+    expected_signal_json = {
+        'files': {
+        },
+        'keywords': {},
+        'failed_targets': [
+            {
+                'target': 'exe',
+            },
+        ]
+    }
+
+    self._RunTest(
+        failure_log, extractors.CompileStepExtractor, expected_signal_json)
+
   def testCheckPermExtractor(self):
     failure_log = textwrap.dedent("""
         a/b/c.py
         ...
         FAILED whitespace.txt
         d/e/f.py
         ...""")
     expected_signal_json = {
         'files': {
             'd/e/f.py': []
@@ skipping 227 matching lines @@
         # step_name: result
         '1': '1',
         '2': '2',
         '32434': '0'
     }
 
     for step_name, expected_result in cases.iteritems():
       result = extractors.ExtractSignal(
           'master', 'bot', step_name, 'test', '')
       self.assertEqual(expected_result, result)