Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Side by Side Diff: appengine/findit/handlers/test/config_test.py

Issue 1799313002: [Findit] Collect failed output nodes of compile and link failures by strict regex (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Support Android besides Mac/Linux/CrOS Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/handlers/config.py ('k') | appengine/findit/waterfall/extractors.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import datetime 5 import datetime
6 import json 6 import json
7 import re 7 import re
8 import webapp2 8 import webapp2
9 import webtest 9 import webtest
10 10
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 384
385 def testValidateTrybotMapping(self): 385 def testValidateTrybotMapping(self):
386 self.assertTrue(config._ValidateTrybotMapping({ 386 self.assertTrue(config._ValidateTrybotMapping({
387 'master1': { 387 'master1': {
388 'builder1': { 388 'builder1': {
389 'mastername': 'tryserver1', 389 'mastername': 'tryserver1',
390 'buildername': 'trybot1', 390 'buildername': 'trybot1',
391 } 391 }
392 } 392 }
393 })) 393 }))
394 self.assertTrue(config._ValidateTrybotMapping({
395 'master1': {
396 'builder1': {
397 'mastername': 'tryserver1',
398 'buildername': 'trybot1',
399 'strict_regex': True,
400 }
401 }
402 }))
403 self.assertFalse(config._ValidateTrybotMapping({
404 'master1': {
405 'builder1': {
406 'mastername': 'tryserver1',
407 'buildername': 'trybot1',
408 'strict_regex': 'a',
409 }
410 }
411 }))
394 self.assertFalse(config._ValidateTrybotMapping(['a'])) 412 self.assertFalse(config._ValidateTrybotMapping(['a']))
395 self.assertFalse(config._ValidateTrybotMapping({'a': ['b']})) 413 self.assertFalse(config._ValidateTrybotMapping({'a': ['b']}))
396 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': ['1']}})) 414 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': ['1']}}))
397 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': {}}})) 415 self.assertFalse(config._ValidateTrybotMapping({'a': {'b': {}}}))
398 416
399 def testValidateTryJobSettings(self): 417 def testValidateTryJobSettings(self):
400 self.assertFalse(config._ValidateTryJobSettings([])) 418 self.assertFalse(config._ValidateTryJobSettings([]))
401 self.assertFalse(config._ValidateTryJobSettings({})) 419 self.assertFalse(config._ValidateTryJobSettings({}))
402 self.assertFalse(config._ValidateTryJobSettings({ 420 self.assertFalse(config._ValidateTryJobSettings({
403 'server_query_interval_seconds': '1', # Should be an int. 421 'server_query_interval_seconds': '1', # Should be an int.
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 'builders': _MOCK_BUILDERS_TO_TRYBOTS, 613 'builders': _MOCK_BUILDERS_TO_TRYBOTS,
596 'try_job_settings': _MOCK_TRY_JOB_SETTINGS, 614 'try_job_settings': _MOCK_TRY_JOB_SETTINGS,
597 'swarming_settings': _MOCK_SWARMING_SETTINGS, 615 'swarming_settings': _MOCK_SWARMING_SETTINGS,
598 'version': 1, 616 'version': 1,
599 'latest_version': 1, 617 'latest_version': 1,
600 'updated_by': 'test', 618 'updated_by': 'test',
601 'updated_ts': response.json_body.get('updated_ts') 619 'updated_ts': response.json_body.get('updated_ts')
602 } 620 }
603 621
604 self.assertEquals(expected_response, response.json_body) 622 self.assertEquals(expected_response, response.json_body)
OLDNEW
« no previous file with comments | « appengine/findit/handlers/config.py ('k') | appengine/findit/waterfall/extractors.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698