[Findit] Collect failed output nodes of compile and link failures by strict regex

appengine/findit/waterfall/try_job_util.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.api import modules
 from google.appengine.ext import ndb
 
 from model import wf_analysis_status
@@ skipping 99 matching lines @@
       else:
         need_new_try_job = False
     else:
       try_job = WfTryJob.Create(
           master_name, builder_name, build_number)
       try_job.put()
 
   return need_new_try_job, last_pass, try_job_type, targeted_tests
 
 
-def _GetFailedTargetsFromSignals(signals):
+def _GetFailedTargetsFromSignals(signals, master_name, builder_name):
   compile_targets = []
 
   if not signals or 'compile' not in signals:
     return compile_targets
 
+  strict_regex = waterfall_config.EnableStrictRegexForCompileLinkFailures(
+      master_name, builder_name)
   for source_target in signals['compile']['failed_targets']:
     # Link failures have only targets but no source. TODO(lijeffrey):
     # Currently only link failures on linux are supported. Add support for
     # compile failures and other platforms as well.
     if not source_target.get('source'):

[lijeffrey, 2016/03/15 07:12:26]

nit: I think this if can be simplified to

if not source_target.get('source') or strict_regex:
  compile_targets.append(source_target.get('target'))

[stgao, 2016/03/15 18:32:21]

sg. Done.

       compile_targets.append(source_target.get('target'))
+    elif strict_regex:
+      # Use object files as the compile targets on bots that we use strict
+      # regex to extract such information.
+      compile_targets.append(source_target.get('target'))
 
   return compile_targets
 
 
 def ScheduleTryJobIfNeeded(failure_info, signals=None, build_completed=False):
   # Do not schedule try-jobs or Swarming tasks until the build is completed.
   if not build_completed:
     return {}
 
   master_name = failure_info['master_name']
   builder_name = failure_info['builder_name']
   build_number = failure_info['build_number']
   failed_steps = failure_info.get('failed_steps', [])
   builds = failure_info.get('builds', {})
 
   tryserver_mastername, tryserver_buildername = (
       waterfall_config.GetTrybotForWaterfallBuilder(master_name, builder_name))
   if not tryserver_mastername or not tryserver_buildername:
     logging.info('%s, %s is not supported yet.', master_name, builder_name)
     return {}
 
   failure_result_map = {}
   need_new_try_job, last_pass, try_job_type, targeted_tests = (
       _NeedANewTryJob(master_name, builder_name, build_number,
                       failed_steps, failure_result_map))
 
   if need_new_try_job:
-    compile_targets = (_GetFailedTargetsFromSignals(signals)
+    compile_targets = (_GetFailedTargetsFromSignals(
+        signals, master_name, builder_name)
                        if try_job_type == TryJobType.COMPILE else None)
 
     pipeline = (
         swarming_tasks_to_try_job_pipeline.SwarmingTasksToTryJobPipeline(
             master_name, builder_name, build_number,
             builds[str(last_pass)]['chromium_revision'],
             builds[str(build_number)]['chromium_revision'],
             builds[str(build_number)]['blame_list'],
             try_job_type, compile_targets, targeted_tests))
 
@@ skipping 11 matching lines @@
               pipeline.pipeline_status_path, try_job_type)
     else:  # pragma: no cover
       logging_str = (
           'Try job was scheduled for build %s, %s, %s: %s because of %s '
           'failure.') % (
               master_name, builder_name, build_number,
               pipeline.pipeline_status_path, try_job_type)
     logging.info(logging_str)
 
   return failure_result_map