Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: appengine/findit/waterfall/test/try_job_util_test.py

Issue 1799313002: [Findit] Collect failed output nodes of compile and link failures by strict regex (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Support Android besides Mac/Linux/CrOS Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from testing_utils import testing 5 from testing_utils import testing
6 6
7 from model import wf_analysis_status 7 from model import wf_analysis_status
8 from model.wf_analysis import WfAnalysis 8 from model.wf_analysis import WfAnalysis
9 from model.wf_try_job import WfTryJob 9 from model.wf_try_job import WfTryJob
10 from waterfall import try_job_util 10 from waterfall import try_job_util
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 _MockRootPipeline.STARTED = False 374 _MockRootPipeline.STARTED = False
375 375
376 try_job_util.ScheduleTryJobIfNeeded(failure_info, build_completed=True) 376 try_job_util.ScheduleTryJobIfNeeded(failure_info, build_completed=True)
377 377
378 try_job = WfTryJob.Get(master_name, builder_name, build_number) 378 try_job = WfTryJob.Get(master_name, builder_name, build_number)
379 379
380 self.assertTrue(_MockRootPipeline.STARTED) 380 self.assertTrue(_MockRootPipeline.STARTED)
381 self.assertIsNotNone(try_job) 381 self.assertIsNotNone(try_job)
382 382
383 def testGetFailedTargetsFromSignals(self): 383 def testGetFailedTargetsFromSignals(self):
384 self.assertEqual(try_job_util._GetFailedTargetsFromSignals({}), []) 384 self.assertEqual(
385 try_job_util._GetFailedTargetsFromSignals({}, 'm', 'b'), [])
385 386
386 signals = { 387 signals = {
387 'compile': { 388 'compile': {
388 'failed_targets': [ 389 'failed_targets': [
389 {'target': 'a.exe'}, 390 {'target': 'a.exe'},
390 {'source': 'b.cc', 391 {'source': 'b.cc',
391 'target': 'b.o'}] 392 'target': 'b.o'}]
392 } 393 }
393 } 394 }
394 395
395 self.assertEqual( 396 self.assertEqual(
396 try_job_util._GetFailedTargetsFromSignals(signals), ['a.exe']) 397 try_job_util._GetFailedTargetsFromSignals(signals, 'm', 'b'), ['a.exe'])
398
399 def testUseObjectFilesAsFailedTargetIfStrictRegexUsed(self):
400 def Mocked_EnableStrictRegexForCompileLinkFailures(*_):
401 return True
402 self.mock(waterfall_config, 'EnableStrictRegexForCompileLinkFailures',
403 Mocked_EnableStrictRegexForCompileLinkFailures)
404
405 signals = {
406 'compile': {
407 'failed_targets': [
408 {'source': 'b.cc', 'target': 'b.o'},
409 ]
410 }
411 }
412
413 self.assertEqual(
414 try_job_util._GetFailedTargetsFromSignals(signals, 'm', 'b'), ['b.o'])
OLDNEW
« no previous file with comments | « appengine/findit/waterfall/test/extractors_test.py ('k') | appengine/findit/waterfall/test/waterfall_config_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698