Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745393002: Subzero. ARM32. Reverts cl 1687553002. (Closed)

Created:
4 years, 9 months ago by John
Modified:
4 years, 9 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -597 lines) Patch
M src/IceTargetLoweringARM32.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
D tests_lit/assembler/arm32/call.ll View 1 chunk +0 lines, -45 lines 0 comments Download
M tests_lit/assembler/arm32/popmult.ll View 2 chunks +6 lines, -6 lines 0 comments Download
M tests_lit/assembler/arm32/push-pop.ll View 2 chunks +123 lines, -32 lines 0 comments Download
M tests_lit/assembler/arm32/rem-vec.ll View 3 chunks +39 lines, -47 lines 0 comments Download
M tests_lit/assembler/arm32/sandboxing.ll View 14 chunks +17 lines, -42 lines 0 comments Download
M tests_lit/assembler/arm32/vpush.ll View 2 chunks +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 11 chunks +20 lines, -44 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 7 chunks +13 lines, -22 lines 0 comments Download
M tests_lit/llvm2ice_tests/arith.ll View 6 chunks +15 lines, -25 lines 0 comments Download
M tests_lit/llvm2ice_tests/bool-folding.ll View 2 chunks +2 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 7 chunks +27 lines, -53 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.arith.ll View 2 chunks +2 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.arm.call.ll View 32 chunks +40 lines, -120 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.cmp.ll View 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/large_stack_offs.ll View 3 chunks +5 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll View 28 chunks +29 lines, -83 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 3 chunks +4 lines, -12 lines 0 comments Download
M tests_lit/llvm2ice_tests/nonsfi.ll View 2 chunks +2 lines, -10 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 chunk +4 lines, -12 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
John
4 years, 9 months ago (2016-03-01 00:03:30 UTC) #2
Jim Stichnoth
lgtm
4 years, 9 months ago (2016-03-01 00:05:21 UTC) #3
John
4 years, 9 months ago (2016-03-01 14:11:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b82d79aa65de2fa913eddb9e291d717a83af6633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698