Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1678003002: Remove sampling trace events from the binding layer (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove sampling trace events from the binding layer This CL decreases the binary size by 600 KB by removing the sampling trace events from the binding layer. As far as I know, the sampling profiler is not widely used recently, so it wouldn't be a big deal to remove them. Also if we really want to have the sampling events in the binding layer, we should add the events to the V8 side (c.f., now V8 supports tracing) and thus avoid bloating the binary size by adding the events to each C++ callback of DOM attribute/method/constant etc. BUG= Committed: https://crrev.com/af52acb6123c993d6eb63ba653b023292eda88eb Cr-Commit-Position: refs/heads/master@{#374106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1967 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 4 chunks +1 line, -33 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 6 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/constants.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 11 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 4 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 3 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 3 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 3 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 188 chunks +0 lines, -236 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 23 chunks +0 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 6 chunks +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 22 chunks +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 13 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 18 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 5 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 9 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 604 chunks +0 lines, -1216 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 5 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 14 chunks +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 47 chunks +0 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
haraken
PTAL
4 years, 10 months ago (2016-02-08 05:15:48 UTC) #2
Yuki
LGTM Now then, we don't always need Xxx{Getter,Setter,Method}Callback function in addition to Xxx{Getter,Setter,Method}. We can ...
4 years, 10 months ago (2016-02-08 05:47:55 UTC) #3
haraken
> Now then, we don't always need Xxx{Getter,Setter,Method}Callback function in > addition to Xxx{Getter,Setter,Method}. We ...
4 years, 10 months ago (2016-02-08 05:50:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678003002/1
4 years, 10 months ago (2016-02-08 05:51:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/170526)
4 years, 10 months ago (2016-02-08 08:58:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1678003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1678003002/1
4 years, 10 months ago (2016-02-08 09:02:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 12:01:23 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 12:02:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af52acb6123c993d6eb63ba653b023292eda88eb
Cr-Commit-Position: refs/heads/master@{#374106}

Powered by Google App Engine
This is Rietveld 408576698