Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
950 } 950 }
951 951
952 PassRefPtr<TracedValue> devToolsTraceEventData(v8::Isolate* isolate, ExecutionCo ntext* context, v8::Local<v8::Function> function) 952 PassRefPtr<TracedValue> devToolsTraceEventData(v8::Isolate* isolate, ExecutionCo ntext* context, v8::Local<v8::Function> function)
953 { 953 {
954 DevToolsFunctionInfo info(function); 954 DevToolsFunctionInfo info(function);
955 return InspectorFunctionCallEvent::data(context, info.scriptId(), info.resou rceName(), info.lineNumber()); 955 return InspectorFunctionCallEvent::data(context, info.scriptId(), info.resou rceName(), info.lineNumber());
956 } 956 }
957 957
958 void v8ConstructorAttributeGetter(v8::Local<v8::Name> propertyName, const v8::Pr opertyCallbackInfo<v8::Value>& info) 958 void v8ConstructorAttributeGetter(v8::Local<v8::Name> propertyName, const v8::Pr opertyCallbackInfo<v8::Value>& info)
959 { 959 {
960 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
961 v8::Local<v8::Value> data = info.Data(); 960 v8::Local<v8::Value> data = info.Data();
962 ASSERT(data->IsExternal()); 961 ASSERT(data->IsExternal());
963 V8PerContextData* perContextData = V8PerContextData::from(info.Holder()->Cre ationContext()); 962 V8PerContextData* perContextData = V8PerContextData::from(info.Holder()->Cre ationContext());
964 if (!perContextData) 963 if (!perContextData)
965 return; 964 return;
966 v8SetReturnValue(info, perContextData->constructorForType(WrapperTypeInfo::u nwrap(data))); 965 v8SetReturnValue(info, perContextData->constructorForType(WrapperTypeInfo::u nwrap(data)));
967 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
968 } 966 }
969 967
970 } // namespace blink 968 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698