Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
index 1f971b2c1a934178690d3c4720c34c85a0ba972e..a2f23fee86b6064203c4c429ab673caf1a8bbd62 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
@@ -50,9 +50,7 @@ static void attr1AttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info
static void attr1AttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
TestInterfaceGarbageCollectedV8Internal::attr1AttributeGetter(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void attr1AttributeSetter(v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -72,9 +70,7 @@ static void attr1AttributeSetter(v8::Local<v8::Value> v8Value, const v8::Functio
static void attr1AttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
v8::Local<v8::Value> v8Value = info[0];
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
TestInterfaceGarbageCollectedV8Internal::attr1AttributeSetter(v8Value, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -97,9 +93,7 @@ static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void funcMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::funcMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void keysMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -117,9 +111,7 @@ static void keysMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void keysMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::keysMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void valuesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -137,9 +129,7 @@ static void valuesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void valuesMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::valuesMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void entriesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -157,9 +147,7 @@ static void entriesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void entriesMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::entriesMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void forEachMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -192,9 +180,7 @@ static void forEachMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void forEachMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::forEachMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void hasMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -223,9 +209,7 @@ static void hasMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void hasMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::hasMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void addMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -254,9 +238,7 @@ static void addMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void addMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::addMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void clearMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -273,9 +255,7 @@ static void clearMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void clearMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::clearMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void deleteMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -304,9 +284,7 @@ static void deleteMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void deleteMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::deleteMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void iteratorMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -324,9 +302,7 @@ static void iteratorMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void iteratorMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterfaceGarbageCollectedV8Internal::iteratorMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -367,7 +343,6 @@ const V8DOMConfiguration::MethodConfiguration V8TestInterfaceGarbageCollectedMet
void V8TestInterfaceGarbageCollected::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMConstructor");
if (!info.IsConstructCall()) {
V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::constructorNotCallableAsFunction("TestInterfaceGarbageCollected"));
return;

Powered by Google App Engine
This is Rietveld 408576698