third_party/WebKit/Source/bindings/templates/interface.cpp - Issue 1678003002: Remove sampling trace events from the binding layer

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/constants.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp b/third_party/WebKit/Source/bindings/templates/interface.cpp

index 01c71ef4ef362d0cca4891ceaad345ab7c7d70a9..344b798b2e4c3044d160f8a6b304afdbaf1ceb34 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp

@@ -40,13 +40,11 @@ static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo

{% set getter = indexed_property_getter %}

static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMIndexedProperty");

{% if getter.is_custom %}

{{v8_class}}::indexedPropertyGetterCustom(index, info);

{% else %}

{{cpp_class}}V8Internal::indexedPropertyGetter(index, info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -103,13 +101,11 @@ static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> v8Value,

{% set setter = indexed_property_setter %}

static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMIndexedProperty");

{% if setter.is_custom %}

{{v8_class}}::indexedPropertySetterCustom(index, v8Value, info);

{% else %}

{{cpp_class}}V8Internal::indexedPropertySetter(index, v8Value, info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -154,13 +150,11 @@ static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInf

{% set deleter = indexed_property_deleter %}

static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMIndexedProperty");

{% if deleter.is_custom %}

{{v8_class}}::indexedPropertyDeleterCustom(index, info);

{% else %}

{{cpp_class}}V8Internal::indexedPropertyDeleter(index, info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -208,13 +202,11 @@ static void namedPropertyGetter(v8::Local<v8::Name> name, const v8::PropertyCall

{% set getter = named_property_getter %}

static void namedPropertyGetterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");

{% if getter.is_custom %}

{{v8_class}}::namedPropertyGetterCustom(name, info);

{% else %}

{{cpp_class}}V8Internal::namedPropertyGetter(name, info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -279,13 +271,11 @@ static void namedPropertySetter(v8::Local<v8::Name> name, v8::Local<v8::Value> v

{% set setter = named_property_setter %}

static void namedPropertySetterCallback(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");

{% if setter.is_custom %}

{{v8_class}}::namedPropertySetterCustom(name, v8Value, info);

{% else %}

{{cpp_class}}V8Internal::namedPropertySetter(name, v8Value, info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -328,13 +318,11 @@ static void namedPropertyQuery(v8::Local<v8::Name> name, const v8::PropertyCallb

{% set getter = named_property_getter %}

static void namedPropertyQueryCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Integer>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");

{% if getter.is_custom_property_query %}

{{v8_class}}::namedPropertyQueryCustom(name, info);

{% else %}

{{cpp_class}}V8Internal::namedPropertyQuery(name, info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -383,13 +371,11 @@ static void namedPropertyDeleter(v8::Local<v8::Name> name, const v8::PropertyCal

{% set deleter = named_property_deleter %}

static void namedPropertyDeleterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");

{% if deleter.is_custom %}

{{v8_class}}::namedPropertyDeleterCustom(name, info);

{% else %}

{{cpp_class}}V8Internal::namedPropertyDeleter(name, info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -426,13 +412,11 @@ static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& i

{% set getter = named_property_getter %}

static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::Array>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");

{% if getter.is_custom_property_enumerator %}

{{v8_class}}::namedPropertyEnumeratorCustom(info);

{% else %}

{{cpp_class}}V8Internal::namedPropertyEnumerator(info);

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -461,9 +445,7 @@ static void {{cpp_class}}OriginSafeMethodSetter(v8::Local<v8::Name> name, v8::Lo

static void {{cpp_class}}OriginSafeMethodSetterCallback(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");

{{cpp_class}}V8Internal::{{cpp_class}}OriginSafeMethodSetter(name, v8Value, info);

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endif %}

@@ -496,7 +478,6 @@ v8::Local<v8::FunctionTemplate> {{v8_class}}Constructor::domTemplate(v8::Isolate

if (!result.IsEmpty())

return result;

- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "BuildDOMTemplate");

result = v8::FunctionTemplate::New(isolate, {{v8_class}}ConstructorCallback);

v8::Local<v8::ObjectTemplate> instanceTemplate = result->InstanceTemplate();

instanceTemplate->SetInternalFieldCount({{v8_class}}::internalFieldCount);

@@ -588,7 +569,6 @@ void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script

{% if constructors or has_custom_constructor or has_event_constructor %}

void {{v8_class}}::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMConstructor");

{% if measure_as %}

UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::{{measure_as('Constructor')}});

{% endif %}