third_party/WebKit/Source/bindings/templates/constants.cpp - Issue 1678003002: Remove sampling trace events from the binding layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/constants.cpp

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/constants.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/constants.cpp b/third_party/WebKit/Source/bindings/templates/constants.cpp

index 8814b25f7f8936797d46191ccd8de24597946cf3..06b8ae79ccb0f4ae55838d8e883a0955b4f8f61f 100644

--- a/third_party/WebKit/Source/bindings/templates/constants.cpp

+++ b/third_party/WebKit/Source/bindings/templates/constants.cpp

@@ -4,7 +4,6 @@

{% macro constant_getter_callback(constant) %}

static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

{% if constant.deprecate_as %}

UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::{{constant.deprecate_as}});

{% endif %}

@@ -21,7 +20,6 @@ static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v

{% else %}

v8SetReturnValueInt(info, {{constant.value}});

{% endif %}

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

{% endmacro %}