third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp - Issue 1678003002: Remove sampling trace events from the binding layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

index 5a69ffff18fad06d9171ef1f59d58ff693d03963..e491557e0577ee63d43c3ae1d0d2618713ff36a5 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

@@ -46,9 +46,7 @@ static void readonlyUnsignedShortAttributeAttributeGetter(const v8::FunctionCall

static void readonlyUnsignedShortAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

TestExceptionV8Internal::readonlyUnsignedShortAttributeAttributeGetter(info);

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

static void readonlyStringAttributeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -60,9 +58,7 @@ static void readonlyStringAttributeAttributeGetter(const v8::FunctionCallbackInf

static void readonlyStringAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

TestExceptionV8Internal::readonlyStringAttributeAttributeGetter(info);

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -73,9 +69,7 @@ static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

static void toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");

TestExceptionV8Internal::toStringMethod(info);

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -111,7 +105,6 @@ const V8DOMConfiguration::MethodConfiguration V8TestExceptionMethods[] = {

void V8TestException::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMConstructor");

if (!info.IsConstructCall()) {

V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::constructorNotCallableAsFunction("TestException"));

return;