third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp - Issue 1678003002: Remove sampling trace events from the binding layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp

index 40868618c7f3015f17a72a64c361e8731549cbbe..80a80b1f3980a402993e3400ae3811547445735a 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp

@@ -47,9 +47,7 @@ static void readonlyStringAttributeAttributeGetter(const v8::FunctionCallbackInf

static void readonlyStringAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

TestInterfaceEventInitConstructorV8Internal::readonlyStringAttributeAttributeGetter(info);

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

static void isTrustedAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -61,9 +59,7 @@ static void isTrustedAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>&

static void isTrustedAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

TestInterfaceEventInitConstructorV8Internal::isTrustedAttributeGetter(info);

- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -103,7 +99,6 @@ const V8DOMConfiguration::AccessorConfiguration V8TestInterfaceEventInitConstruc

void V8TestInterfaceEventInitConstructor::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMConstructor");

if (!info.IsConstructCall()) {

V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::constructorNotCallableAsFunction("TestInterfaceEventInitConstructor"));

return;