Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp

Issue 1678003002: Remove sampling trace events from the binding layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
index 4eac55673911d5a2dfc87a458cb7ae9736d99be1..dd15d9c6b22c41a24804a08bdfa2a648f28e3a1a 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
@@ -68,9 +68,7 @@ static void itemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void itemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::itemMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void setItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -105,9 +103,7 @@ static void setItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void setItemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::setItemMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void deleteItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -135,9 +131,7 @@ static void deleteItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void deleteItemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::deleteItemMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -165,9 +159,7 @@ static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void namedItemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::namedItemMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void setNamedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -202,9 +194,7 @@ static void setNamedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void setNamedItemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::setNamedItemMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void deleteNamedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -232,9 +222,7 @@ static void deleteNamedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& inf
static void deleteNamedItemMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::deleteNamedItemMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void stringifierMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -245,9 +233,7 @@ static void stringifierMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& i
static void stringifierMethodMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::stringifierMethodMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void keysMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -265,9 +251,7 @@ static void keysMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void keysMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::keysMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void valuesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -285,9 +269,7 @@ static void valuesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void valuesMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::valuesMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void entriesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -305,9 +287,7 @@ static void entriesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void entriesMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::entriesMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void forEachMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -340,9 +320,7 @@ static void forEachMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void forEachMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::forEachMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void hasMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -374,9 +352,7 @@ static void hasMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void hasMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::hasMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -387,9 +363,7 @@ static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::toStringMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void iteratorMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -407,9 +381,7 @@ static void iteratorMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
static void iteratorMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod");
TestInterface2V8Internal::iteratorMethod(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -434,9 +406,7 @@ static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo
static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMIndexedProperty");
TestInterface2V8Internal::indexedPropertyGetter(index, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -459,9 +429,7 @@ static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> v8Value,
static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMIndexedProperty");
TestInterface2V8Internal::indexedPropertySetter(index, v8Value, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
@@ -477,9 +445,7 @@ static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInf
static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMIndexedProperty");
TestInterface2V8Internal::indexedPropertyDeleter(index, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void namedPropertyGetter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -499,9 +465,7 @@ static void namedPropertyGetter(v8::Local<v8::Name> name, const v8::PropertyCall
static void namedPropertyGetterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");
TestInterface2V8Internal::namedPropertyGetter(name, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void namedPropertySetter(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -529,9 +493,7 @@ static void namedPropertySetter(v8::Local<v8::Name> name, v8::Local<v8::Value> v
static void namedPropertySetterCallback(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");
TestInterface2V8Internal::namedPropertySetter(name, v8Value, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void namedPropertyQuery(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
@@ -550,9 +512,7 @@ static void namedPropertyQuery(v8::Local<v8::Name> name, const v8::PropertyCallb
static void namedPropertyQueryCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");
TestInterface2V8Internal::namedPropertyQuery(name, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void namedPropertyDeleter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
@@ -570,9 +530,7 @@ static void namedPropertyDeleter(v8::Local<v8::Name> name, const v8::PropertyCal
static void namedPropertyDeleterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");
TestInterface2V8Internal::namedPropertyDeleter(name, info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
@@ -593,9 +551,7 @@ static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& i
static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMNamedProperty");
TestInterface2V8Internal::namedPropertyEnumerator(info);
- TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
}
} // namespace TestInterface2V8Internal
@@ -629,7 +585,6 @@ const V8DOMConfiguration::MethodConfiguration V8TestInterface2Methods[] = {
void V8TestInterface2::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- TRACE_EVENT_SCOPED_SAMPLING_STATE("blink", "DOMConstructor");
if (!info.IsConstructCall()) {
V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::constructorNotCallableAsFunction("TestInterface2"));
return;
« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698