Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, caseq+blink_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, lushnikov+blink_chromium.org, plaree+watch_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. BUG=580337 Committed: https://crrev.com/303520d6d745807a04f43f9704edbdcff33d1dbf Cr-Commit-Position: refs/heads/master@{#373612}

Patch Set 1 #

Patch Set 2 : #

Total comments: 15

Patch Set 3 : review comments addressed #

Patch Set 4 : rebaselined #

Patch Set 5 : testts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -376 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-exception-while-no-inspector.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-document-initiator.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/resources/stacktrace-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-enabled/console/console-uncaught-promise-no-inspector-expected.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-reload.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-operation-breakpoints.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-operation-events.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 2 chunks +1 line, -6 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ScriptCallFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ScriptCallStack.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp View 1 2 2 chunks +23 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp View 2 chunks +7 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 2 7 chunks +22 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 1 2 3 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js View 1 2 1 chunk +16 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileDataGrid.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/promises/PromisePane.js View 1 2 5 chunks +7 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 6 chunks +20 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/AsyncOperationsSidebarPane.js View 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js View 12 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 3 4 8 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 5 chunks +30 lines, -43 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pfeldman
4 years, 10 months ago (2016-02-04 00:01:58 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1666563005/diff/20001/third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp File third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp (right): https://codereview.chromium.org/1666563005/diff/20001/third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp#newcode50 third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp:50: m_description = description; nit: use initializer syntax https://codereview.chromium.org/1666563005/diff/20001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp ...
4 years, 10 months ago (2016-02-04 01:43:06 UTC) #3
pfeldman
https://codereview.chromium.org/1666563005/diff/20001/third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp File third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp (right): https://codereview.chromium.org/1666563005/diff/20001/third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp#newcode50 third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp:50: m_description = description; On 2016/02/04 01:43:06, dgozman wrote: > ...
4 years, 10 months ago (2016-02-04 03:16:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666563005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666563005/60001
4 years, 10 months ago (2016-02-04 05:28:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176161) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 10 months ago (2016-02-04 06:45:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666563005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666563005/80001
4 years, 10 months ago (2016-02-04 17:16:37 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-04 20:52:09 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 20:53:22 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/303520d6d745807a04f43f9704edbdcff33d1dbf
Cr-Commit-Position: refs/heads/master@{#373612}

Powered by Google App Engine
This is Rietveld 408576698