third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: testts Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileDataGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 406dd1d03876848106a25670f01b0a4cfa4d6c90..708e04b8b78b069a9fc127dd63cdb5b0e53d9a83 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -1231,7 +1231,7 @@ WebInspector.NetworkLogView.prototype = {

anchor = element.enclosingNodeOrSelfWithClass("network-script-initiated");

if (anchor && anchor.request) {

var initiator = /** @type {!WebInspector.NetworkRequest} */ (anchor.request).initiator();

- if (initiator && (initiator.stackTrace || initiator.asyncStackTrace))

+ if (initiator && initiator.stack)

return anchor;

}

@@ -1246,7 +1246,7 @@ WebInspector.NetworkLogView.prototype = {

if (anchor.classList.contains("network-script-initiated")) {

var request = /** @type {!WebInspector.NetworkRequest} */ (anchor.request);

var initiator = /** @type {!NetworkAgent.Initiator} */ (request.initiator());

- content = WebInspector.DOMPresentationUtils.buildStackTracePreviewContents(request.target(), this._popupLinkifier, initiator.stackTrace, initiator.asyncStackTrace);

+ content = WebInspector.DOMPresentationUtils.buildStackTracePreviewContents(request.target(), this._popupLinkifier, initiator.stack);

popover.setCanShrink(true);

} else {

content = WebInspector.RequestTimingView.createTimingTable(anchor.parentElement.request, this._timeCalculator.minimumBoundary());