Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Side by Side Diff: third_party/WebKit/Source/core/inspector/ScriptCallFrame.cpp

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: testts Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 , m_column(column) 51 , m_column(column)
52 { 52 {
53 } 53 }
54 54
55 ScriptCallFrame::~ScriptCallFrame() 55 ScriptCallFrame::~ScriptCallFrame()
56 { 56 {
57 } 57 }
58 58
59 // buildInspectorObject() and toTracedValue() should set the same fields. 59 // buildInspectorObject() and toTracedValue() should set the same fields.
60 // If either of them is modified, the other should be also modified. 60 // If either of them is modified, the other should be also modified.
61 PassRefPtr<TypeBuilder::Console::CallFrame> ScriptCallFrame::buildInspectorObjec t() const 61 PassRefPtr<TypeBuilder::Runtime::CallFrame> ScriptCallFrame::buildInspectorObjec t() const
62 { 62 {
63 return TypeBuilder::Console::CallFrame::create() 63 return TypeBuilder::Runtime::CallFrame::create()
64 .setFunctionName(m_functionName) 64 .setFunctionName(m_functionName)
65 .setScriptId(m_scriptId) 65 .setScriptId(m_scriptId)
66 .setUrl(m_scriptName) 66 .setUrl(m_scriptName)
67 .setLineNumber(m_lineNumber) 67 .setLineNumber(m_lineNumber)
68 .setColumnNumber(m_column) 68 .setColumnNumber(m_column)
69 .release(); 69 .release();
70 } 70 }
71 71
72 void ScriptCallFrame::toTracedValue(TracedValue* value) const 72 void ScriptCallFrame::toTracedValue(TracedValue* value) const
73 { 73 {
74 value->beginDictionary(); 74 value->beginDictionary();
75 value->setString("functionName", m_functionName); 75 value->setString("functionName", m_functionName);
76 value->setString("scriptId", m_scriptId); 76 value->setString("scriptId", m_scriptId);
77 value->setString("url", m_scriptName); 77 value->setString("url", m_scriptName);
78 value->setInteger("lineNumber", m_lineNumber); 78 value->setInteger("lineNumber", m_lineNumber);
79 value->setInteger("columnNumber", m_column); 79 value->setInteger("columnNumber", m_column);
80 value->endDictionary(); 80 value->endDictionary();
81 } 81 }
82 82
83 } // namespace blink 83 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/inspector/ScriptCallFrame.h ('k') | third_party/WebKit/Source/core/inspector/ScriptCallStack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698