third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: testts Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

index 6b3773600bc3bc94a33cce085e987829574ad249..0f66b56b2209243d9d9862a35c5dd1b6df198982 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

@@ -84,11 +84,12 @@ WebInspector.PresentationConsoleMessageHelper.prototype = {

var debuggerModel = WebInspector.DebuggerModel.fromTarget(message.target());

if (!debuggerModel)

return null;

+ var callFrame = message.stackTrace && message.stackTrace.callFrames ? message.stackTrace.callFrames[0] : null;

// FIXME(62725): stack trace line/column numbers are one-based.

- var lineNumber = message.stackTrace ? message.stackTrace[0].lineNumber - 1 : message.line - 1;

+ var lineNumber = callFrame ? callFrame.lineNumber - 1 : message.line - 1;

var columnNumber = message.column ? message.column - 1 : 0;

- if (message.stackTrace && message.stackTrace[0].columnNumber)

- columnNumber = message.stackTrace[0].columnNumber - 1;

+ if (callFrame && callFrame.columnNumber)

+ columnNumber = callFrame.columnNumber - 1;

if (message.scriptId)

return debuggerModel.createRawLocationByScriptId(message.scriptId, lineNumber, columnNumber);

return debuggerModel.createRawLocationByURL(message.url || "", lineNumber, columnNumber);