Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: testts Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 937afd06621c1061411ddfac9bf82d60e53d3c11..0de41e3f99203e28a2c706a6109e96bec7b696e0 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -215,7 +215,7 @@ WebInspector.ConsoleViewMessage.prototype = {
} else {
var showBlackboxed = (consoleMessage.source !== WebInspector.ConsoleMessage.MessageSource.ConsoleAPI);
var debuggerModel = WebInspector.DebuggerModel.fromTarget(this._target());
- var callFrame = WebInspector.DebuggerPresentationUtils.callFrameAnchorFromStackTrace(debuggerModel, consoleMessage.stackTrace, consoleMessage.asyncStackTrace, showBlackboxed);
+ var callFrame = WebInspector.DebuggerPresentationUtils.callFrameAnchorFromStackTrace(debuggerModel, consoleMessage.stackTrace, showBlackboxed);
if (callFrame && callFrame.scriptId)
this._anchorElement = this._linkifyCallFrame(callFrame);
else if (consoleMessage.url && consoleMessage.url !== "undefined")
@@ -230,7 +230,7 @@ WebInspector.ConsoleViewMessage.prototype = {
this._formattedMessage.insertBefore(this._anchorElement, this._formattedMessage.firstChild);
}
- var dumpStackTrace = (!!consoleMessage.stackTrace || !!consoleMessage.asyncStackTrace) && (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError || consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace);
+ var dumpStackTrace = !!consoleMessage.stackTrace && (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError || consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace);
if (dumpStackTrace) {
var treeOutline = new TreeOutline();
treeOutline.element.classList.add("outline-disclosure", "outline-disclosure-no-padding");
@@ -276,7 +276,7 @@ WebInspector.ConsoleViewMessage.prototype = {
},
/**
- * @param {!ConsoleAgent.CallFrame} callFrame
+ * @param {!RuntimeAgent.CallFrame} callFrame
* @return {?Element}
*/
_linkifyCallFrame: function(callFrame)
@@ -1013,8 +1013,7 @@ WebInspector.ConsoleViewMessage.prototype = {
var target = this._target();
if (!target)
return;
- var content = WebInspector.DOMPresentationUtils.buildStackTracePreviewContents(target,
- this._linkifier, this._message.stackTrace, this._message.asyncStackTrace);
+ var content = WebInspector.DOMPresentationUtils.buildStackTracePreviewContents(target, this._linkifier, this._message.stackTrace);
var treeElement = new TreeElement(content);
treeElement.selectable = false;
parentTreeElement.appendChild(treeElement);

Powered by Google App Engine
This is Rietveld 408576698