third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: testts Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp ('k') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h

index 7638483476347f5ebea6e29293e1267533e16b27..72b7da93d304f729c506855e6ad8e5369d98580c 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h

@@ -16,7 +16,7 @@ class InjectedScript;

class InjectedScriptManager;

class JSONObject;

class RemoteCallFrameId;

-class ScriptAsyncCallStack;

+class ScriptCallStack;

class V8Debugger;

typedef String ErrorString;

@@ -97,7 +97,7 @@ public:

virtual void removeBreakpoint(const String& scriptId, int lineNumber, int columnNumber, BreakpointSource) = 0;

// Async call stacks implementation

- virtual PassRefPtr<ScriptAsyncCallStack> currentAsyncStackTraceForConsole() = 0;

+ virtual PassRefPtr<ScriptCallStack> currentAsyncStackTraceForConsole() = 0;

static const int unknownAsyncOperationId;

virtual int traceAsyncOperationStarting(const String& description) = 0;

virtual void traceAsyncCallbackStarting(int operationId) = 0;