third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp - Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: testts Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ScriptCallStack.cpp ('k') | third_party/WebKit/Source/core/inspector/v8/PromiseTracker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp b/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp

index 55ff6cbab46977b732a9683e33d19d2fcb91483a..fc4e0d0e23401940cd18657fcc370f74faa1005f 100644

--- a/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp

@@ -75,7 +75,7 @@ static PassRefPtr<TypeBuilder::Runtime::ExceptionDetails> toExceptionDetails(Pas

RefPtr<JSONArray> stackTrace = object->getArray("stackTrace");

if (stackTrace && stackTrace->length() > 0) {

- RefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame>> frames = TypeBuilder::Array<TypeBuilder::Console::CallFrame>::create();

+ RefPtr<TypeBuilder::Array<TypeBuilder::Runtime::CallFrame>> frames = TypeBuilder::Array<TypeBuilder::Runtime::CallFrame>::create();

for (unsigned i = 0; i < stackTrace->length(); ++i) {

RefPtr<JSONObject> stackFrame = stackTrace->get(i)->asObject();

int lineNumber = 0;

@@ -92,7 +92,7 @@ static PassRefPtr<TypeBuilder::Runtime::ExceptionDetails> toExceptionDetails(Pas

String functionName;

stackFrame->getString("functionName", &functionName);

- RefPtr<TypeBuilder::Console::CallFrame> callFrame = TypeBuilder::Console::CallFrame::create()

+ RefPtr<TypeBuilder::Runtime::CallFrame> callFrame = TypeBuilder::Runtime::CallFrame::create()

.setFunctionName(functionName)

.setScriptId(String::number(scriptId))

.setUrl(sourceURL)

@@ -101,7 +101,9 @@ static PassRefPtr<TypeBuilder::Runtime::ExceptionDetails> toExceptionDetails(Pas

frames->addItem(callFrame.release());

}

- exceptionDetails->setStackTrace(frames.release());

+ RefPtr<TypeBuilder::Runtime::StackTrace> stack = TypeBuilder::Runtime::StackTrace::create()

+ .setCallFrames(frames.release());

+ exceptionDetails->setStack(stack.release());

}

if (originScriptId)

exceptionDetails->setScriptId(String::number(originScriptId));