Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptCallStack.h

Issue 1666563005: DevTools: merge ScriptCallStack and ScriptAsyncCallStack, move CallStacks from console to Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: testts Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ScriptCallStack.h
diff --git a/third_party/WebKit/Source/core/inspector/ScriptCallStack.h b/third_party/WebKit/Source/core/inspector/ScriptCallStack.h
index a71a3edddb93b9383bac94266248affd236e05e3..724f79965341b1cbda6ec9a9531e19051584831c 100644
--- a/third_party/WebKit/Source/core/inspector/ScriptCallStack.h
+++ b/third_party/WebKit/Source/core/inspector/ScriptCallStack.h
@@ -40,7 +40,6 @@
namespace blink {
-class ScriptAsyncCallStack;
class TracedValue;
class CORE_EXPORT ScriptCallStack final : public RefCounted<ScriptCallStack> {
@@ -48,23 +47,24 @@ public:
static const size_t maxCallStackSizeToCapture = 200;
static PassRefPtr<ScriptCallStack> create(Vector<ScriptCallFrame>&);
+ static PassRefPtr<ScriptCallStack> create(const String& description, Vector<ScriptCallFrame>&, PassRefPtr<ScriptCallStack>);
~ScriptCallStack();
const ScriptCallFrame &at(size_t) const;
size_t size() const;
- PassRefPtr<ScriptAsyncCallStack> asyncCallStack() const;
- void setAsyncCallStack(PassRefPtr<ScriptAsyncCallStack>);
+ void setParent(PassRefPtr<ScriptCallStack>);
- PassRefPtr<TypeBuilder::Array<TypeBuilder::Console::CallFrame> > buildInspectorArray() const;
+ PassRefPtr<TypeBuilder::Runtime::StackTrace> buildInspectorObject() const;
void toTracedValue(TracedValue*, const char* name) const;
private:
- explicit ScriptCallStack(Vector<ScriptCallFrame>&);
+ ScriptCallStack(const String& description, Vector<ScriptCallFrame>& frames, PassRefPtr<ScriptCallStack> parent);
+ String m_description;
Vector<ScriptCallFrame> m_frames;
- RefPtr<ScriptAsyncCallStack> m_asyncCallStack;
+ RefPtr<ScriptCallStack> m_parent;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698