VectorICs: Remove --vector-stores flag.

VectorICs: Remove --vector-stores flag.

BUG=

Committed: https://crrev.com/e75e625453b4bf53b60dd620e8c6907a90b20b46
Cr-Commit-Position: refs/heads/master@{#32040}

[mvstanton, 2015-10-30 09:37:19]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org

[mvstanton, 2015-10-30 09:37:20]

Hi Benedikt, we could land this after another week, if all goes well, thx!
--Michael

[Michael Hablich, 2015-10-30 10:38:43]

On 2015/10/30 09:37:20, mvstanton wrote:
> Hi Benedikt, we could land this after another week, if all goes well, thx!
> --Michael

We will make the branch cut for M48 ~ 13th November. This means we will enter
API freeze phase ~ 6th November (Friday next week). 

Is it correct that the impact one V8 runtime behavior will be low because it
'just' removes the flag?I can image that a spread CL like this will make it hard
to revert stuff. So landing it before the 6th November is preferable.

WDYT?

[mvstanton, 2015-10-30 12:20:10]

Hi Michael, actually we should wait until after, just to have the "safety
hatch." I think CLs that need to be backmerged are 95% okay, because most of
this CL is just removing dead code.

[Benedikt Meurer, 2015-11-16 08:29:50]

LGTM.

[mvstanton, 2015-11-17 11:34:38]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-11-17 11:34:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1424153003/#ps100001
(title: "REBASE.")

[commit-bot: I haz the power, 2015-11-17 11:35:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424153003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424153003/100001

[commit-bot: I haz the power, 2015-11-17 11:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 11:37:38]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7786)

[Hannes Payer (out of office), 2015-11-17 12:14:30]

hpayer@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2015-11-17 12:14:31]

https://codereview.chromium.org/1424153003/diff/100001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1424153003/diff/100001/src/heap/heap.cc#newco...
src/heap/heap.cc:502: void Heap::ClearAllKeyedStoreICs() {
The heap does not need to know anymore about:
TypeFeedbackVector::ClearAllKeyedStoreICs(isolate_);
Can we call that function directly when needed?

[mvstanton, 2015-11-17 12:37:46]

Hi Hannes, can you take a look again?
thx,
--Mike

https://codereview.chromium.org/1424153003/diff/100001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1424153003/diff/100001/src/heap/heap.cc#newco...
src/heap/heap.cc:502: void Heap::ClearAllKeyedStoreICs() {
On 2015/11/17 12:14:31, Hannes Payer wrote:
> The heap does not need to know anymore about:
> TypeFeedbackVector::ClearAllKeyedStoreICs(isolate_);
> Can we call that function directly when needed?

Done.

[Hannes Payer (out of office), 2015-11-17 13:04:56]

Thanks, LGTM.

[Michael Lippautz, 2015-11-17 13:05:35]

On 2015/11/17 12:37:46, mvstanton wrote:
> Hi Hannes, can you take a look again?
> thx,
> --Mike
> 

dbc: Please refrain from calling yourself Mike!

-Mike ;)

[mvstanton, 2015-11-17 13:06:36]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-11-17 13:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1424153003/#ps120001
(title: "Response to Hannes comment.")

[commit-bot: I haz the power, 2015-11-17 13:06:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424153003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424153003/120001

[commit-bot: I haz the power, 2015-11-17 13:15:34]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-11-17 13:16:01]

Patchset 7 (id:??) landed as
https://crrev.com/e75e625453b4bf53b60dd620e8c6907a90b20b46
Cr-Commit-Position: refs/heads/master@{#32040}