Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: test/cctest/compiler/test-run-bytecode-graph-builder.cc

Issue 1424153003: VectorICs: Remove --vector-stores flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Response to Hannes comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(jochen): Remove this after the setting is turned on globally. 5 // TODO(jochen): Remove this after the setting is turned on globally.
6 #define V8_IMMINENT_DEPRECATION_WARNINGS 6 #define V8_IMMINENT_DEPRECATION_WARNINGS
7 7
8 #include <utility> 8 #include <utility>
9 9
10 #include "src/compiler/pipeline.h" 10 #include "src/compiler/pipeline.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 Handle<JSFunction> function_; 57 Handle<JSFunction> function_;
58 }; 58 };
59 59
60 60
61 class BytecodeGraphTester { 61 class BytecodeGraphTester {
62 public: 62 public:
63 BytecodeGraphTester(Isolate* isolate, Zone* zone, const char* script) 63 BytecodeGraphTester(Isolate* isolate, Zone* zone, const char* script)
64 : isolate_(isolate), zone_(zone), script_(script) { 64 : isolate_(isolate), zone_(zone), script_(script) {
65 i::FLAG_ignition = true; 65 i::FLAG_ignition = true;
66 i::FLAG_always_opt = false; 66 i::FLAG_always_opt = false;
67 i::FLAG_vector_stores = true;
68 // Set ignition filter flag via SetFlagsFromString to avoid double-free 67 // Set ignition filter flag via SetFlagsFromString to avoid double-free
69 // (or potential leak with StrDup() based on ownership confusion). 68 // (or potential leak with StrDup() based on ownership confusion).
70 ScopedVector<char> ignition_filter(64); 69 ScopedVector<char> ignition_filter(64);
71 SNPrintF(ignition_filter, "--ignition-filter=%s", kFunctionName); 70 SNPrintF(ignition_filter, "--ignition-filter=%s", kFunctionName);
72 FlagList::SetFlagsFromString(ignition_filter.start(), 71 FlagList::SetFlagsFromString(ignition_filter.start(),
73 ignition_filter.length()); 72 ignition_filter.length());
74 // Ensure handler table is generated. 73 // Ensure handler table is generated.
75 isolate->interpreter()->Initialize(); 74 isolate->interpreter()->Initialize();
76 } 75 }
77 virtual ~BytecodeGraphTester() {} 76 virtual ~BytecodeGraphTester() {}
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 auto callable = tester.GetCallable<Handle<Object>>(); 327 auto callable = tester.GetCallable<Handle<Object>>();
329 Handle<Object> return_value = 328 Handle<Object> return_value =
330 callable(snippets[i].parameter(0)).ToHandleChecked(); 329 callable(snippets[i].parameter(0)).ToHandleChecked();
331 CHECK(return_value->SameValue(*snippets[i].return_value())); 330 CHECK(return_value->SameValue(*snippets[i].return_value()));
332 } 331 }
333 } 332 }
334 333
335 } // namespace compiler 334 } // namespace compiler
336 } // namespace internal 335 } // namespace internal
337 } // namespace v8 336 } // namespace v8
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698