Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: test/cctest/interpreter/test-interpreter.cc

Issue 1424153003: VectorICs: Remove --vector-stores flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Response to Hannes comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/cctest/test-feedback-vector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(rmcilroy): Remove this define after this flag is turned on globally 5 // TODO(rmcilroy): Remove this define after this flag is turned on globally
6 #define V8_IMMINENT_DEPRECATION_WARNINGS 6 #define V8_IMMINENT_DEPRECATION_WARNINGS
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/execution.h" 10 #include "src/execution.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 class InterpreterTester { 60 class InterpreterTester {
61 public: 61 public:
62 InterpreterTester(Isolate* isolate, const char* source, 62 InterpreterTester(Isolate* isolate, const char* source,
63 MaybeHandle<BytecodeArray> bytecode, 63 MaybeHandle<BytecodeArray> bytecode,
64 MaybeHandle<TypeFeedbackVector> feedback_vector, 64 MaybeHandle<TypeFeedbackVector> feedback_vector,
65 const char* filter) 65 const char* filter)
66 : isolate_(isolate), 66 : isolate_(isolate),
67 source_(source), 67 source_(source),
68 bytecode_(bytecode), 68 bytecode_(bytecode),
69 feedback_vector_(feedback_vector) { 69 feedback_vector_(feedback_vector) {
70 i::FLAG_vector_stores = true;
71 i::FLAG_ignition = true; 70 i::FLAG_ignition = true;
72 i::FLAG_ignition_fake_try_catch = true; 71 i::FLAG_ignition_fake_try_catch = true;
73 i::FLAG_always_opt = false; 72 i::FLAG_always_opt = false;
74 // Set ignition filter flag via SetFlagsFromString to avoid double-free 73 // Set ignition filter flag via SetFlagsFromString to avoid double-free
75 // (or potential leak with StrDup() based on ownership confusion). 74 // (or potential leak with StrDup() based on ownership confusion).
76 ScopedVector<char> ignition_filter(64); 75 ScopedVector<char> ignition_filter(64);
77 SNPrintF(ignition_filter, "--ignition-filter=%s", filter); 76 SNPrintF(ignition_filter, "--ignition-filter=%s", filter);
78 FlagList::SetFlagsFromString(ignition_filter.start(), 77 FlagList::SetFlagsFromString(ignition_filter.start(),
79 ignition_filter.length()); 78 ignition_filter.length());
80 // Ensure handler table is generated. 79 // Ensure handler table is generated.
(...skipping 2866 matching lines...) Expand 10 before | Expand all | Expand 10 after
2947 callable().ToHandleChecked(); 2946 callable().ToHandleChecked();
2948 2947
2949 Handle<Object> new_target_name = v8::Utils::OpenHandle( 2948 Handle<Object> new_target_name = v8::Utils::OpenHandle(
2950 *CompileRun("(function() { return (new f()).a.name; })();")); 2949 *CompileRun("(function() { return (new f()).a.name; })();"));
2951 CHECK(new_target_name->SameValue(*factory->NewStringFromStaticChars("f"))); 2950 CHECK(new_target_name->SameValue(*factory->NewStringFromStaticChars("f")));
2952 } 2951 }
2953 2952
2954 } // namespace interpreter 2953 } // namespace interpreter
2955 } // namespace internal 2954 } // namespace internal
2956 } // namespace v8 2955 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | test/cctest/test-feedback-vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698