Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: src/type-info.cc

Issue 1424153003: VectorICs: Remove --vector-stores flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Response to Hannes comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-info.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/type-info.cc
diff --git a/src/type-info.cc b/src/type-info.cc
index c049af18cbb6d33a3e9e218c8b7cc74e4cc63bc0..6971c1fd5e49096786ce73de4607969685fe3907 100644
--- a/src/type-info.cc
+++ b/src/type-info.cc
@@ -72,19 +72,6 @@ Handle<Object> TypeFeedbackOracle::GetInfo(FeedbackVectorSlot slot) {
}
-InlineCacheState TypeFeedbackOracle::LoadInlineCacheState(TypeFeedbackId id) {
- Handle<Object> maybe_code = GetInfo(id);
- if (maybe_code->IsCode()) {
- Handle<Code> code = Handle<Code>::cast(maybe_code);
- if (code->is_inline_cache_stub()) return code->ic_state();
- }
-
- // If we can't find an IC, assume we've seen *something*, but we don't know
- // what. PREMONOMORPHIC roughly encodes this meaning.
- return PREMONOMORPHIC;
-}
-
-
InlineCacheState TypeFeedbackOracle::LoadInlineCacheState(
FeedbackVectorSlot slot) {
if (!slot.IsInvalid()) {
@@ -104,14 +91,6 @@ InlineCacheState TypeFeedbackOracle::LoadInlineCacheState(
}
-bool TypeFeedbackOracle::StoreIsUninitialized(TypeFeedbackId ast_id) {
- Handle<Object> maybe_code = GetInfo(ast_id);
- if (!maybe_code->IsCode()) return false;
- Handle<Code> code = Handle<Code>::cast(maybe_code);
- return code->ic_state() == UNINITIALIZED;
-}
-
-
bool TypeFeedbackOracle::StoreIsUninitialized(FeedbackVectorSlot slot) {
if (!slot.IsInvalid()) {
FeedbackVectorSlotKind kind = feedback_vector_->GetKind(slot);
@@ -157,24 +136,6 @@ byte TypeFeedbackOracle::ForInType(FeedbackVectorSlot feedback_vector_slot) {
void TypeFeedbackOracle::GetStoreModeAndKeyType(
- TypeFeedbackId ast_id, KeyedAccessStoreMode* store_mode,
- IcCheckType* key_type) {
- Handle<Object> maybe_code = GetInfo(ast_id);
- if (maybe_code->IsCode()) {
- Handle<Code> code = Handle<Code>::cast(maybe_code);
- if (code->kind() == Code::KEYED_STORE_IC) {
- ExtraICState extra_ic_state = code->extra_ic_state();
- *store_mode = KeyedStoreIC::GetKeyedAccessStoreMode(extra_ic_state);
- *key_type = KeyedStoreIC::GetKeyType(extra_ic_state);
- return;
- }
- }
- *store_mode = STANDARD_STORE;
- *key_type = ELEMENT;
-}
-
-
-void TypeFeedbackOracle::GetStoreModeAndKeyType(
FeedbackVectorSlot slot, KeyedAccessStoreMode* store_mode,
IcCheckType* key_type) {
if (!slot.IsInvalid() &&
@@ -232,12 +193,6 @@ Handle<AllocationSite> TypeFeedbackOracle::GetCallNewAllocationSite(
}
-bool TypeFeedbackOracle::LoadIsBuiltin(
- TypeFeedbackId id, Builtins::Name builtin) {
- return *GetInfo(id) == isolate()->builtins()->builtin(builtin);
-}
-
-
void TypeFeedbackOracle::CompareType(TypeFeedbackId id,
Type** left_type,
Type** right_type,
@@ -351,15 +306,6 @@ void TypeFeedbackOracle::KeyedPropertyReceiverTypes(
}
-void TypeFeedbackOracle::AssignmentReceiverTypes(TypeFeedbackId id,
- Handle<Name> name,
- SmallMapList* receiver_types) {
- receiver_types->Clear();
- Code::Flags flags = Code::ComputeHandlerFlags(Code::STORE_IC);
- CollectReceiverTypes(id, name, flags, receiver_types);
-}
-
-
void TypeFeedbackOracle::AssignmentReceiverTypes(FeedbackVectorSlot slot,
Handle<Name> name,
SmallMapList* receiver_types) {
@@ -370,15 +316,6 @@ void TypeFeedbackOracle::AssignmentReceiverTypes(FeedbackVectorSlot slot,
void TypeFeedbackOracle::KeyedAssignmentReceiverTypes(
- TypeFeedbackId id, SmallMapList* receiver_types,
- KeyedAccessStoreMode* store_mode, IcCheckType* key_type) {
- receiver_types->Clear();
- CollectReceiverTypes(id, receiver_types);
- GetStoreModeAndKeyType(id, store_mode, key_type);
-}
-
-
-void TypeFeedbackOracle::KeyedAssignmentReceiverTypes(
FeedbackVectorSlot slot, SmallMapList* receiver_types,
KeyedAccessStoreMode* store_mode, IcCheckType* key_type) {
receiver_types->Clear();
@@ -387,13 +324,6 @@ void TypeFeedbackOracle::KeyedAssignmentReceiverTypes(
}
-void TypeFeedbackOracle::CountReceiverTypes(TypeFeedbackId id,
- SmallMapList* receiver_types) {
- receiver_types->Clear();
- CollectReceiverTypes(id, receiver_types);
-}
-
-
void TypeFeedbackOracle::CountReceiverTypes(FeedbackVectorSlot slot,
SmallMapList* receiver_types) {
receiver_types->Clear();
@@ -410,19 +340,6 @@ void TypeFeedbackOracle::CollectReceiverTypes(FeedbackVectorSlot slot,
}
-void TypeFeedbackOracle::CollectReceiverTypes(TypeFeedbackId ast_id,
- Handle<Name> name,
- Code::Flags flags,
- SmallMapList* types) {
- Handle<Object> object = GetInfo(ast_id);
- if (object->IsUndefined() || object->IsSmi()) return;
-
- DCHECK(object->IsCode());
- Handle<Code> code(Handle<Code>::cast(object));
- CollectReceiverTypes<Code>(*code, name, flags, types);
-}
-
-
template <class T>
void TypeFeedbackOracle::CollectReceiverTypes(T* obj, Handle<Name> name,
Code::Flags flags,
@@ -438,15 +355,6 @@ void TypeFeedbackOracle::CollectReceiverTypes(T* obj, Handle<Name> name,
}
-void TypeFeedbackOracle::CollectReceiverTypes(TypeFeedbackId ast_id,
- SmallMapList* types) {
- Handle<Object> object = GetInfo(ast_id);
- if (!object->IsCode()) return;
- Handle<Code> code = Handle<Code>::cast(object);
- CollectReceiverTypes<Code>(*code, types);
-}
-
-
void TypeFeedbackOracle::CollectReceiverTypes(FeedbackVectorSlot slot,
SmallMapList* types) {
FeedbackVectorSlotKind kind = feedback_vector_->GetKind(slot);
« no previous file with comments | « src/type-info.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698