Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: src/ic/ic-inl.h

Issue 1424153003: VectorICs: Remove --vector-stores flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Response to Hannes comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/ic/mips/access-compiler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_INL_H_ 5 #ifndef V8_IC_INL_H_
6 #define V8_IC_INL_H_ 6 #define V8_IC_INL_H_
7 7
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 9
10 #include "src/compiler.h" 10 #include "src/compiler.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 53
54 void IC::SetTargetAtAddress(Address address, Code* target, 54 void IC::SetTargetAtAddress(Address address, Code* target,
55 Address constant_pool) { 55 Address constant_pool) {
56 if (AddressIsDeoptimizedCode(target->GetIsolate(), address)) return; 56 if (AddressIsDeoptimizedCode(target->GetIsolate(), address)) return;
57 57
58 DCHECK(target->is_inline_cache_stub() || target->is_compare_ic_stub()); 58 DCHECK(target->is_inline_cache_stub() || target->is_compare_ic_stub());
59 59
60 DCHECK(!target->is_inline_cache_stub() || 60 DCHECK(!target->is_inline_cache_stub() ||
61 (target->kind() != Code::LOAD_IC && 61 (target->kind() != Code::LOAD_IC &&
62 target->kind() != Code::KEYED_LOAD_IC && 62 target->kind() != Code::KEYED_LOAD_IC &&
63 target->kind() != Code::CALL_IC && 63 target->kind() != Code::CALL_IC && target->kind() != Code::STORE_IC &&
64 (!FLAG_vector_stores || (target->kind() != Code::STORE_IC && 64 target->kind() != Code::KEYED_STORE_IC));
65 target->kind() != Code::KEYED_STORE_IC))));
66 65
67 Heap* heap = target->GetHeap(); 66 Heap* heap = target->GetHeap();
68 Code* old_target = GetTargetAtAddress(address, constant_pool); 67 Code* old_target = GetTargetAtAddress(address, constant_pool);
69 #ifdef DEBUG 68 #ifdef DEBUG
70 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark 69 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark
71 // ICs as language mode. The language mode of the IC must be preserved. 70 // ICs as language mode. The language mode of the IC must be preserved.
72 if (old_target->kind() == Code::STORE_IC || 71 if (old_target->kind() == Code::STORE_IC ||
73 old_target->kind() == Code::KEYED_STORE_IC) { 72 old_target->kind() == Code::KEYED_STORE_IC) {
74 DCHECK(StoreICState::GetLanguageMode(old_target->extra_ic_state()) == 73 DCHECK(StoreICState::GetLanguageMode(old_target->extra_ic_state()) ==
75 StoreICState::GetLanguageMode(target->extra_ic_state())); 74 StoreICState::GetLanguageMode(target->extra_ic_state()));
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 bool IC::AddressIsDeoptimizedCode(Isolate* isolate, Address address) { 176 bool IC::AddressIsDeoptimizedCode(Isolate* isolate, Address address) {
178 Code* host = 177 Code* host =
179 isolate->inner_pointer_to_code_cache()->GetCacheEntry(address)->code; 178 isolate->inner_pointer_to_code_cache()->GetCacheEntry(address)->code;
180 return (host->kind() == Code::OPTIMIZED_FUNCTION && 179 return (host->kind() == Code::OPTIMIZED_FUNCTION &&
181 host->marked_for_deoptimization()); 180 host->marked_for_deoptimization());
182 } 181 }
183 } // namespace internal 182 } // namespace internal
184 } // namespace v8 183 } // namespace v8
185 184
186 #endif // V8_IC_INL_H_ 185 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/ic/mips/access-compiler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698