Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 1424153003: VectorICs: Remove --vector-stores flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Response to Hannes comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/access-compiler-mips.cc ('k') | src/ic/mips/ic-compiler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/ic/call-optimization.h" 7 #include "src/ic/call-optimization.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 ExternalReference ref = ExternalReference(&fun, type, masm->isolate()); 290 ExternalReference ref = ExternalReference(&fun, type, masm->isolate());
291 __ li(api_function_address, Operand(ref)); 291 __ li(api_function_address, Operand(ref));
292 292
293 // Jump to stub. 293 // Jump to stub.
294 CallApiAccessorStub stub(isolate, is_store, call_data_undefined); 294 CallApiAccessorStub stub(isolate, is_store, call_data_undefined);
295 __ TailCallStub(&stub); 295 __ TailCallStub(&stub);
296 } 296 }
297 297
298 298
299 static void StoreIC_PushArgs(MacroAssembler* masm) { 299 static void StoreIC_PushArgs(MacroAssembler* masm) {
300 if (FLAG_vector_stores) { 300 __ Push(StoreDescriptor::ReceiverRegister(), StoreDescriptor::NameRegister(),
301 __ Push(StoreDescriptor::ReceiverRegister(), 301 StoreDescriptor::ValueRegister(),
302 StoreDescriptor::NameRegister(), StoreDescriptor::ValueRegister(), 302 VectorStoreICDescriptor::SlotRegister(),
303 VectorStoreICDescriptor::SlotRegister(), 303 VectorStoreICDescriptor::VectorRegister());
304 VectorStoreICDescriptor::VectorRegister());
305 } else {
306 __ Push(StoreDescriptor::ReceiverRegister(),
307 StoreDescriptor::NameRegister(), StoreDescriptor::ValueRegister());
308 }
309 } 304 }
310 305
311 306
312 void NamedStoreHandlerCompiler::GenerateSlow(MacroAssembler* masm) { 307 void NamedStoreHandlerCompiler::GenerateSlow(MacroAssembler* masm) {
313 StoreIC_PushArgs(masm); 308 StoreIC_PushArgs(masm);
314 309
315 // The slow case calls into the runtime to complete the store without causing 310 // The slow case calls into the runtime to complete the store without causing
316 // an IC miss that would otherwise cause a transition to the generic stub. 311 // an IC miss that would otherwise cause a transition to the generic stub.
317 __ TailCallRuntime(Runtime::kStoreIC_Slow, FLAG_vector_stores ? 5 : 3, 1); 312 __ TailCallRuntime(Runtime::kStoreIC_Slow, 5, 1);
318 } 313 }
319 314
320 315
321 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) { 316 void ElementHandlerCompiler::GenerateStoreSlow(MacroAssembler* masm) {
322 StoreIC_PushArgs(masm); 317 StoreIC_PushArgs(masm);
323 318
324 // The slow case calls into the runtime to complete the store without causing 319 // The slow case calls into the runtime to complete the store without causing
325 // an IC miss that would otherwise cause a transition to the generic stub. 320 // an IC miss that would otherwise cause a transition to the generic stub.
326 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow, FLAG_vector_stores ? 5 : 3, 321 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow, 5, 1);
327 1);
328 } 322 }
329 323
330 324
331 #undef __ 325 #undef __
332 #define __ ACCESS_MASM(masm()) 326 #define __ ACCESS_MASM(masm())
333 327
334 328
335 void NamedStoreHandlerCompiler::GenerateRestoreName(Label* label, 329 void NamedStoreHandlerCompiler::GenerateRestoreName(Label* label,
336 Handle<Name> name) { 330 Handle<Name> name) {
337 if (!label->is_unused()) { 331 if (!label->is_unused()) {
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
780 // Return the generated code. 774 // Return the generated code.
781 return GetCode(kind(), Code::NORMAL, name); 775 return GetCode(kind(), Code::NORMAL, name);
782 } 776 }
783 777
784 778
785 #undef __ 779 #undef __
786 } // namespace internal 780 } // namespace internal
787 } // namespace v8 781 } // namespace v8
788 782
789 #endif // V8_TARGET_ARCH_MIPS 783 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/mips/access-compiler-mips.cc ('k') | src/ic/mips/ic-compiler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698