Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: src/code-stubs.h

Issue 1424153003: VectorICs: Remove --vector-stores flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Response to Hannes comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index d69e9263e14a12195031d4423e380dc9a16cf348..ef0682a74bfe58afa03ff031fff2d27f11cb3900 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -44,7 +44,6 @@ namespace internal {
V(ProfileEntryHook) \
V(RecordWrite) \
V(RegExpExec) \
- V(StoreArrayLiteralElement) \
V(StoreBufferOverflow) \
V(StoreElement) \
V(StringCompare) \
@@ -1232,20 +1231,15 @@ class StoreTransitionHelper {
}
static Register SlotRegister() {
- DCHECK(FLAG_vector_stores);
return VectorStoreTransitionDescriptor::SlotRegister();
}
static Register VectorRegister() {
- DCHECK(FLAG_vector_stores);
return VectorStoreTransitionDescriptor::VectorRegister();
}
static Register MapRegister() {
- if (FLAG_vector_stores) {
- return VectorStoreTransitionDescriptor::MapRegister();
- }
- return StoreTransitionDescriptor::MapRegister();
+ return VectorStoreTransitionDescriptor::MapRegister();
}
static int ReceiverIndex() {
@@ -1263,7 +1257,6 @@ class StoreTransitionHelper {
}
static int VectorIndex() {
- DCHECK(FLAG_vector_stores);
if (HasVirtualSlotArg()) {
return VectorStoreTransitionDescriptor::kVirtualSlotVectorIndex;
}
@@ -1272,7 +1265,6 @@ class StoreTransitionHelper {
// Some platforms don't have a slot arg.
static bool HasVirtualSlotArg() {
- if (!FLAG_vector_stores) return false;
return SlotRegister().is(no_reg);
}
};
@@ -2566,10 +2558,7 @@ class StoreFastElementStub : public HydrogenCodeStub {
}
CallInterfaceDescriptor GetCallInterfaceDescriptor() const override {
- if (FLAG_vector_stores) {
- return VectorStoreICDescriptor(isolate());
- }
- return StoreDescriptor(isolate());
+ return VectorStoreICDescriptor(isolate());
}
Code::Kind GetCodeKind() const override { return Code::HANDLER; }
@@ -2820,10 +2809,7 @@ class StoreElementStub : public PlatformCodeStub {
}
CallInterfaceDescriptor GetCallInterfaceDescriptor() const override {
- if (FLAG_vector_stores) {
- return VectorStoreICDescriptor(isolate());
- }
- return StoreDescriptor(isolate());
+ return VectorStoreICDescriptor(isolate());
}
Code::Kind GetCodeKind() const override { return Code::HANDLER; }
@@ -2961,16 +2947,6 @@ class ElementsTransitionAndStoreStub : public HydrogenCodeStub {
};
-class StoreArrayLiteralElementStub : public PlatformCodeStub {
- public:
- explicit StoreArrayLiteralElementStub(Isolate* isolate)
- : PlatformCodeStub(isolate) { }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(StoreArrayLiteralElement);
- DEFINE_PLATFORM_CODE_STUB(StoreArrayLiteralElement, PlatformCodeStub);
-};
-
-
class StubFailureTrampolineStub : public PlatformCodeStub {
public:
StubFailureTrampolineStub(Isolate* isolate, StubFunctionMode function_mode)
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698