VectorICs: Remove --vector-stores flag.

test/cctest/test-feedback-vector.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(mvstanton): Remove this define after this flag is turned on globally
 #define V8_IMMINENT_DEPRECATION_WARNINGS
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
@@ skipping 442 matching lines @@
         "}"
         "a = 3;"
         "testvar({});");
 
     Handle<JSFunction> f = GetFunction("testvar");
 
     // There should be two LOAD_ICs, one for a and one for y at the end.
     Handle<TypeFeedbackVector> feedback_vector =
         handle(f->shared()->feedback_vector(), isolate);
     FeedbackVectorHelper helper(feedback_vector);
-    if (FLAG_vector_stores) {
-      CHECK_EQ(4, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::STORE_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::STORE_IC);
-      CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::LOAD_IC);
-    } else {
-      CHECK_EQ(2, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::LOAD_IC);
-    }
+    CHECK_EQ(4, helper.slot_count());
+    CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::STORE_IC);
+    CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::LOAD_IC);
+    CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::STORE_IC);
+    CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::LOAD_IC);
   }
 
   {
     CompileRun(
         "function testprop(x) {"
         "  x.blue = a;"
         "}"
         "testprop({ blue: 3 });");
 
     Handle<JSFunction> f = GetFunction("testprop");
 
     // There should be one LOAD_IC, for the load of a.
     Handle<TypeFeedbackVector> feedback_vector(f->shared()->feedback_vector());
     FeedbackVectorHelper helper(feedback_vector);
-    if (FLAG_vector_stores) {
-      CHECK_EQ(2, helper.slot_count());
-    } else {
-      CHECK_EQ(1, helper.slot_count());
-    }
+    CHECK_EQ(2, helper.slot_count());
   }
 
   {
     CompileRun(
         "function testpropfunc(x) {"
         "  x().blue = a;"
         "  return x().blue;"
         "}"
         "function makeresult() { return { blue: 3 }; }"
         "testpropfunc(makeresult);");
 
     Handle<JSFunction> f = GetFunction("testpropfunc");
 
     // There should be 2 LOAD_ICs and 2 CALL_ICs.
     Handle<TypeFeedbackVector> feedback_vector(f->shared()->feedback_vector());
     FeedbackVectorHelper helper(feedback_vector);
-    if (FLAG_vector_stores) {
-      CHECK_EQ(5, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::CALL_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::STORE_IC);
-      CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::CALL_IC);
-      CHECK_SLOT_KIND(helper, 4, FeedbackVectorSlotKind::LOAD_IC);
-    } else {
-      CHECK_EQ(4, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::CALL_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::CALL_IC);
-      CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::LOAD_IC);
-    }
+    CHECK_EQ(5, helper.slot_count());
+    CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::CALL_IC);
+    CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::LOAD_IC);
+    CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::STORE_IC);
+    CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::CALL_IC);
+    CHECK_SLOT_KIND(helper, 4, FeedbackVectorSlotKind::LOAD_IC);
   }
 
   {
     CompileRun(
         "function testkeyedprop(x) {"
         "  x[0] = a;"
         "  return x[0];"
         "}"
         "testkeyedprop([0, 1, 2]);");
 
     Handle<JSFunction> f = GetFunction("testkeyedprop");
 
     // There should be 1 LOAD_ICs for the load of a, and one KEYED_LOAD_IC for
     // the load of x[0] in the return statement.
     Handle<TypeFeedbackVector> feedback_vector(f->shared()->feedback_vector());
     FeedbackVectorHelper helper(feedback_vector);
-    if (FLAG_vector_stores) {
-      CHECK_EQ(3, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::KEYED_STORE_IC);
-      CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::KEYED_LOAD_IC);
-    } else {
-      CHECK_EQ(2, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::KEYED_LOAD_IC);
-    }
+    CHECK_EQ(3, helper.slot_count());
+    CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_IC);
+    CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::KEYED_STORE_IC);
+    CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::KEYED_LOAD_IC);
   }
 
   {
     CompileRun(
         "function testcompound(x) {"
         "  x.old = x.young = x.in_between = a;"
         "  return x.old + x.young;"
         "}"
         "testcompound({ old: 3, young: 3, in_between: 3 });");
 
     Handle<JSFunction> f = GetFunction("testcompound");
 
     // There should be 3 LOAD_ICs, for load of a and load of x.old and x.young.
     Handle<TypeFeedbackVector> feedback_vector(f->shared()->feedback_vector());
     FeedbackVectorHelper helper(feedback_vector);
-    if (FLAG_vector_stores) {
-      CHECK_EQ(6, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::STORE_IC);
-      CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::STORE_IC);
-      CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::STORE_IC);
-      CHECK_SLOT_KIND(helper, 4, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 5, FeedbackVectorSlotKind::LOAD_IC);
-    } else {
-      CHECK_EQ(3, helper.slot_count());
-      CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::LOAD_IC);
-      CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::LOAD_IC);
-    }
+    CHECK_EQ(6, helper.slot_count());
+    CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_IC);
+    CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::STORE_IC);
+    CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::STORE_IC);
+    CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::STORE_IC);
+    CHECK_SLOT_KIND(helper, 4, FeedbackVectorSlotKind::LOAD_IC);
+    CHECK_SLOT_KIND(helper, 5, FeedbackVectorSlotKind::LOAD_IC);
   }
 }
 
 
 TEST(VectorStoreICBasic) {
   if (i::FLAG_always_opt) return;
-  if (!i::FLAG_vector_stores) return;
 
   CcTest::InitializeVM();
   LocalContext context;
   v8::HandleScope scope(context->GetIsolate());
 
   CompileRun(
       "function f(a) {"
       "  a.foo = 5;"
       "}"
       "var a = { foo: 3 };"
       "f(a);"
       "f(a);"
       "f(a);");
   Handle<JSFunction> f = GetFunction("f");
   // There should be one IC slot.
   Handle<TypeFeedbackVector> feedback_vector(f->shared()->feedback_vector());
   FeedbackVectorHelper helper(feedback_vector);
   CHECK_EQ(1, helper.slot_count());
   FeedbackVectorSlot slot(0);
   StoreICNexus nexus(feedback_vector, slot);
   CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
 }
 
 }  // namespace