Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 14081010: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed)

Created:
7 years, 8 months ago by Elliot Glaysher
Modified:
7 years, 8 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, kinuko+watch, cbentzel+watch_chromium.org, vsevik, benjhayden+dwatch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, yurys, darin-cc_chromium.org, dtseng+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, ctguil+watch_chromium.org, jochen+watch_chromium.org, zork+watch_chromium.org, michaeln, hashimoto+watch_chromium.org, sail+watch_chromium.org, davidbarr+watch_chromium.org, aboxhall+watch_chromium.org, rdsmith+dwatch_chromium.org, James Su, pfeldman
Visibility:
Public.

Description

Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes these in content/. BUG=232084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194608

Patch Set 1 #

Patch Set 2 : Fix some gtk issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -411 lines) Patch
M content/browser/accessibility/accessibility_win_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/content_view_render_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.cc View 11 chunks +15 lines, -15 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M content/browser/byte_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/data_fetcher_impl_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/device_orientation/observer_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/devtools/devtools_protocol.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/base_file.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/drag_download_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/location_arbitrator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/power_save_blocker_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/java/java_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/web_contents_video_capture_device.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_udp_socket_private_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_sandbox_host_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/streams/stream_url_request_job.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_process_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/gl_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 16 chunks +18 lines, -18 lines 0 comments Download
M content/common/gpu/image_transport_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/np_channel_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/npobject_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/resource_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_unittest_helper.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/gpu/gpu_info_collector.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/gpu/gpu_main.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/plugin/plugin_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_browser_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/active_notification_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/browser_plugin/mock_browser_plugin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/stream_texture_host_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/java/java_bridge_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/pepper_platform_video_decoder_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_audio_input_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_broker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_device_enumeration_host_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_file_io_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_platform_context_3d_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_image_2d_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_truetype_font_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_video_capture_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_websocket_host.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/renderer_clipboard_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/v8_value_converter_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/v8_value_converter_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_browser_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_javascript_dialog_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/webkit_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layout_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
This mechanical cleanup patch brought to you by git ls-files | xargs sed -i -e ...
7 years, 8 months ago (2013-04-16 21:55:37 UTC) #1
jam
sorry, I'm a bit overloaded. can you use another content owner?
7 years, 8 months ago (2013-04-16 23:01:13 UTC) #2
Elliot Glaysher
avi: can you rubberstamp this? It's an entirely mechanical change.
7 years, 8 months ago (2013-04-16 23:40:27 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
7 years, 8 months ago (2013-04-17 00:15:02 UTC) #4
Elliot Glaysher
7 years, 8 months ago (2013-04-17 16:43:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r194608 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698